Django

Code

Ticket #8069 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

inconsistent case for class BaseInlineFormset

Reported by: dan90 Assigned to: brosner
Milestone: 1.0 Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

BaseInlineFormset?, unlike all other class names derived from FormSet? classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.

Attachments

ticket8069-1.diff (2.9 kB) - added by dan90 on 08/01/08 00:16:00.
patch addressing inconsistent case of BaseInlineFormSet?

Change History

08/01/08 00:16:00 changed by dan90

  • attachment ticket8069-1.diff added.

patch addressing inconsistent case of BaseInlineFormSet?

08/01/08 00:21:18 changed by dan90

  • status changed from new to assigned.
  • needs_better_patch changed.
  • component changed from Uncategorized to django.newforms.
  • needs_tests changed.
  • summary changed from inconsistent case for class BaseInlilneFormset to inconsistent case for class BaseInlineFormset.
  • owner changed from nobody to dan90.
  • needs_docs changed.

My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.

08/08/08 14:32:48 changed by ericholscher

  • stage changed from Unreviewed to Ready for checkin.
  • milestone set to 1.0.

08/08/08 14:48:49 changed by brosner

  • owner changed from dan90 to brosner.
  • status changed from assigned to new.

08/08/08 15:27:49 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [8243]) Fixed #8069 -- Corrected the inconsistent case with BaseInlineFormset?. It has been renamed to BaseInlineFormSet?. Backward incompatible for anyone who used BaseInlineFormset? directly.

Add/Change #8069 (inconsistent case for class BaseInlineFormset)




Change Properties
Action