admin_scripts tests doesn't work on Jython

[Leo Soto M.]

This set of tests rely on the PYTHONPATH environment variable to set the sys.path of the child python processes it launches and to read the potential location of external backends. But Jython doesn't use PYTHONPATH (nor does IronPython, for the record).

The attached patch fixes this by:

• Tweaking the command line to be executed depending on the current platform.
• Reading the "current PYTHONPATH" from sys.path instead of os.environ['PYTHONPATH'].

It also contains code to remove the compiled files generated from Jython, and avoids a check for the "pyc" extension on the output.

The only drawback I can see is that by using sys.path instead of PYTHONPATH, I've incremented the number places where a pre-existing 'settings.py' file would break the test. Practical example: a settings.py file under <django-root>/tests/.

If it is considered to be worth the effort, this patch could be improved by trying to point the the child's sys.path to only <django-root>, <django-root>/tests/regressiontests/ and <external-backend-root>.

[Leo Soto M.]

Crap, I just realized that the current patch will break the suite on windows where the commandline "PYTHONPATH=foo python" is very likely going to fail (don't have a windows box to confirm it right now).

[Alex Gaynor]

os.pathsep should contain the appropriate string for seperating paths in PYTHONPATH.

[Leo Soto M.]

Well, I didn't explained well enough

With "PYTHONPATH=foo python" I tried to set the python path to foo and launch python in one shot. This way I didn't needed to mess with os.environ['PYTHONPATH'] and only _sys_executable had to deal with different Python VMs.

But it won't work on Windows, so I'm reverting that particular approach on this new patch.

[Russell Keith-Magee]

(In [8158]) Refs #8047 -- Removed some CPython specific parts of the admin scripts tests.

[Russell Keith-Magee]

The sys.path path of the proposed patch doesn't work for me; sys.path includes a lot of things that PYTHONPATH doesn't contain - in particular, the tests directory itself, which causes some of the tests to fail. Any other suggestions for composing PYTHONPATH?

[Leo Soto M.]

Replying to russellm:

The sys.path path of the proposed patch doesn't work for me; sys.path includes a lot of things that PYTHONPATH doesn't contain - in particular, the tests directory itself, which causes some of the tests to fail.

Yeah, that was what I tried to explain on the last two paragraph of the ticket description. The new patch detect where the external backend is located and only adds its parent directory to the child's sys.path.

[Leo Soto M.]

Avoid inheriting the whole sys.path, to the child processes. Now it just tries to detect the location of the external backend.

[magneto]

can i also suggest, while you're at it, to remove the 'Optimized' python bits "*.pyo"?

[Leo Soto M.]

updated to svn r8162

[Leo Soto M.]

I screwed up the patch the last time. Now it is ok

[Jacob]

(In [8238]) Fixed #8047: property detect an external database backend and set sys.path accordingly. Patch from Leo Soto.

[Jacob]

Milestone 1.0 deleted