Django

Code

Ticket #801 (closed: invalid)

Opened 3 years ago

Last modified 2 years ago

contrib.comments seems a bit "unready"

Reported by: hugo Assigned to: adrian
Milestone: Component: django.contrib.comments
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

There are parts in django.contrib.comments that just don't look like it's fully coded. One thing that springs to mind is the support for extra_kwargs in the CommentListNode? class, which is missing any way of passing this from the DoCommentList? function - you can't create any extra_kwargs. Another is the approved and is_public bools that are avaialable, but never tested (I think at least the is_public should be taken into account with the get_comment_count and get_comment_list tags). Then there is the fact that the CommentListNode? class allows extra_kwargs, but the CommentCountNode? doesn't - so even if the tags would allow to pass additional keyword arguments for lookup, the list would respect them, while the count wouldn't.

Maybe this should be fleshed out a bit more before 1.0 ;-)

Attachments

Change History

11/26/06 19:20:15 changed by adrian

  • component changed from Tools to django.contrib.comments.

12/26/06 18:30:43 changed by adrian

  • status changed from new to closed.
  • resolution set to invalid.

Closing this because it's too generic. We're going to rewrite the comments app before documenting it, and that should fix these issues and more.

01/17/07 16:12:17 changed by

  • milestone deleted.

Milestone Version 1.0 deleted


Add/Change #801 (contrib.comments seems a bit "unready")




Change Properties
Action