Django

Code

Ticket #7793 (closed: fixed)

Opened 5 months ago

Last modified 4 months ago

Sitemaps generator does not care about 50,000 URL limit

Reported by: Julian Bez Assigned to: nobody
Milestone: 1.0 beta Component: Contrib apps
Version: SVN Keywords: sitemaps
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

As stated in the protocol, each sitemap must have no more than 50,000 URLs. http://sitemaps.org/protocol.php#index

The current sitemaps generator does not care about the limit and is not suited for larger sets of data.

The patch provided adds the paginator to sitemaps and creates a sitemap for every 50,000 URLs.

Attachments

sitemaps-pagination.diff (3.7 kB) - added by Julian on 07/17/08 08:43:46.
Patch that adds pagination
sitemaps-pagination.2.diff (3.9 kB) - added by julianb on 07/21/08 12:36:09.
Updated: Limit is an attribute now
sitemaps-pagination.3.diff (4.0 kB) - added by julianb on 07/21/08 17:07:38.
Fixed tiny mistake

Change History

07/17/08 08:43:46 changed by Julian

  • attachment sitemaps-pagination.diff added.

Patch that adds pagination

07/18/08 04:13:40 changed by julianb

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

07/18/08 18:24:29 changed by Simon Greenhill

  • stage changed from Unreviewed to Ready for checkin.
  • milestone set to 1.0 beta.

07/21/08 12:36:09 changed by julianb

  • attachment sitemaps-pagination.2.diff added.

Updated: Limit is an attribute now

07/21/08 17:07:38 changed by julianb

  • attachment sitemaps-pagination.3.diff added.

Fixed tiny mistake

07/26/08 00:03:47 changed by mtredinnick

I don't really have any way of testing this, but I've read it through with some care and it looks to be doing the right thing. The docs change might need to be added to a little in the future, since it doesn't really make sense to me and I know what the patch is meant to be doing. So attempts to fix that (in another ticket) will be welcomed.

07/26/08 00:07:16 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [8088]) Fixed #7793 -- Handle sitemaps with more than 50,000 URLs in them (by using pagination). Patch from Julian Bez.

The docs patch here could probably do with some rewording.

Add/Change #7793 (Sitemaps generator does not care about 50,000 URL limit)




Change Properties
Action