Django

Code

Ticket #7732 (new)

Opened 5 months ago

Last modified 3 months ago

Oracle Backend with SessionPool

Reported by: halturin Assigned to: nobody
Milestone: post-1.0 Component: Database layer (models, ORM)
Version: SVN Keywords: yandex-sprint
Cc: halturin@gmail.com, nleschev@gmail.com, ikelly Triage Stage: Design decision needed
Has patch: 1 Needs documentation: 1
Needs tests: 0 Patch needs improvement: 1

Description

This new backend uses Oracle session pool to improve database performance in threaded environment. Overall speedup for large amounts of small queries is 2-3 times.

Attachments

oracle_pool.tar.gz (10.4 kB) - added by halturin on 07/12/08 09:31:51.
Tarball with oracle_pool db backend
oracle_pool.diff (4.3 kB) - added by jbronn on 07/16/08 10:50:01.
Oracle pooling patch derived from tarball.
oracle_pool.2.diff (4.1 kB) - added by ikelly on 07/21/08 11:58:48.
Modified patch with print statements removed
oracle_pool.3.diff (4.7 kB) - added by nleschev on 07/24/08 06:48:24.

Change History

07/12/08 09:31:51 changed by halturin

  • attachment oracle_pool.tar.gz added.

Tarball with oracle_pool db backend

07/13/08 05:43:18 changed by serialx

  • needs_better_patch set to 1.
  • needs_docs set to 1.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • milestone set to post-1.0.

Can you modify the files to conform with Django Patch Style?

And I think adding a new backend needs design decision. By patching the existing oracle backend and making pooling an option seems to be better. Making milestone post-1.0 since modifying or adding feature to the current backend is currently out of scope of 1.0 release.

07/16/08 10:50:01 changed by jbronn

  • attachment oracle_pool.diff added.

Oracle pooling patch derived from tarball.

07/21/08 11:58:48 changed by ikelly

  • attachment oracle_pool.2.diff added.

Modified patch with print statements removed

07/21/08 12:08:25 changed by ikelly

I'm trying to run this through the test suite, and I'm seeing lots of non-deterministic test failures. When I try to run the full test suite, I get an early error where it's setting up the test database and apparently trying to reset a sequence that doesn't exist. When I try to run just the basic test, the test runs, but lots of queries return dramatically incorrect results. It's not obvious where this is coming from, but it needs to be addressed before this can be committed.

07/24/08 06:48:05 changed by nleschev

  • cc set to halturin@gmail.com, nleschev@gmail.com.

We have included all changes in this patch(oracle_pool.3.diff). Also has been added 4 settings.
DATABASE_SESSION_POOL=[True/False]
DATABASE_SESSION_POOL_MIN=1
DATABASE_SESSION_POOL_MAX=3
DATABASE_SESSION_POOL_INCREMENT=1

07/24/08 06:48:24 changed by nleschev

  • attachment oracle_pool.3.diff added.

09/02/08 15:16:06 changed by ikelly

  • cc changed from halturin@gmail.com, nleschev@gmail.com to halturin@gmail.com, nleschev@gmail.com, ikelly.

Add/Change #7732 (Oracle Backend with SessionPool)




Change Properties
Action