Streaming file uploads fail on Windows XP

[justin.driscoll@…]

When you attempt to upload a file larger than the memory cutoff it returns a WindowsError when it attempts to delete the temporary file which still has a handle from the python process because it is not being closed.

[justin.driscoll@…]

Adds a "close" method to TemporaryUploadedFile.

[justin.driscoll@…]

I would also ask the relevant devs to consider adding some exception handling to the file_move_safe function so that even if os.remove(old_file_name) fails the application can continue.

try:

os.remove(old_file_name)

except:

# log the error and continue execution

[justin.driscoll@…]

Last comment reset the summary, etc. Sorry.

[Michael Axiak]

This should be fixed as of [7859], can you please confirm this?

[justin.driscoll@…]

Just updated to the latest revs for both trunk and newforms-admin (7870). Still get the error above in newforms admin but in trunk I now get a IOError "No such file or directory". Here's a snippet of the traceback where it fails:

File "C:\home\Projects\Django\libs\django-trunk\django\core\files\move.py" in file_move_safe

40. file_move(old_file_name, new_file_name)

File "C:\Python25\lib\shutil.py" in move

199. copy2(src,dst)

File "C:\Python25\lib\shutil.py" in copy2

91. copyfile(src, dst)

File "C:\Python25\lib\shutil.py" in copyfile

46. fsrc = open(src, 'rb')

[Michael Axiak]

So it appears there's a reason not to use tempfile.NamedTemporaryFile() on windows. I'm going to create my own NamedTemporaryFile() function for windows.

[Michael Axiak]

New temp module for Windows support

[Michael Axiak]

Someone else should probably look at this, but I think this fixes the problems with Windows.

[justin.driscoll@…]

Still getting the IOError on streaming uploads after applying the new patch.

[Michael Axiak]

Replying to justin.driscoll@gmail.com:

Still getting the IOError on streaming uploads after applying the new patch.

Yeah. That's bug #7675.

[Michael Axiak]

Updated tempfile diff to fix AttributeError problem.

[Michael Axiak]

Updated tempfile diff to fix AttributeError problem.

[justin.driscoll@…]

Just updated to newforms-admin rev 7888 which from what I can see is inline with trunk and now there appears to be an issue with ImageField and streaming uploads as the PIL check for a valid image fails on streamed file. Should I file this as a new issue?

[Alex Gaynor]

Justin, there is already a ticket open for that problem, #7673.

[anonymous]

Thanks, I ran a search but didn't find anything. Wanted to ask before I filed a dupe.

[Andrii Kurinnyi]

It looks like close method for the TemporaryUploadFile deletes file on Linux and Mac systems
(didn't have a chance to test it on FreeBSD yet), see #7683

[Malcolm Tredinnick]

(In [8096]) Fixed #7658 -- Added some Windows-specific tempfile handling. The standard
stuff doesn't work with the way Django's file uploading code wants to operate.
Patch from Mike Axiak.

[justin.driscoll@…]

As of Django r8301 I am still getting a WindowsError when streaming uploads are used:

[Error 32] The process cannot access the file because it is being used by another process: 'c:
docume~1
jdrisc~1
locals~1
temp
eu5ium.upload'

[Julien Phalip]

Same issue is reported in #8203.

[Julien Phalip]

Re-resolving as 'fixed', since the newly reported issue is a *new* one and most likely the same as in #8203. I consider it's a new issue since the problem is now not with the streaming upload, namely, but within the storage phase.