Django

Code

Ticket #7621 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

Use super(..., cls).__new__ instead of type.__new__ in metaclasses django.db.models.ModelBase and django.newforms.forms.DeclarativeFieldsMetaclass

Reported by: Christian Tanzer <tanzer@swing.co.at> Assigned to: nobody
Milestone: Component: Uncategorized
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation:
Needs tests: Patch needs improvement:

Description

As discussed on django-developers@googlegroups.com, here is a patch for django.db.models.ModelBase?.new and django.newforms.forms.DeclarativeFieldsMetaclass?.new to use super instead of type to chain up.

Attachments

metaclass.diff (1.7 kB) - added by Christian Tanzer <tanzer@swing.co.at> on 07/03/08 07:44:01.

Change History

07/03/08 07:44:01 changed by Christian Tanzer <tanzer@swing.co.at>

  • attachment metaclass.diff added.

07/06/08 06:55:32 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7846]) Fixed #7621 -- Enable superclassing of the various metaclasses we use.

Also tidy up some initialisation code in django.db.models.base.ModelBase?. Thanks, Christian Tanzer.

Add/Change #7621 (Use super(..., cls).__new__ instead of type.__new__ in metaclasses django.db.models.ModelBase and django.newforms.forms.DeclarativeFieldsMetaclass)




Change Properties
Action