changeset 7574 broke form.save(commit=False) on FK fields

[omat@…]

When trying to save a ModelForm instance with a not null foreign key without specifying the FK field but saving with commit=False

form.save(commit=False)

raises ValueError as per the following code introduced in the changeset [7574]:

...
        if value is None and self.field.null == False: 
 		            raise ValueError('Cannot assign None: "%s.%s" does not allow null values.' % 
 		                                (instance._meta.object_name, self.field.name)) 
...

commit=False should be regarded when checking for ValueError.

[Collin Grady]

I don't see the use case where this would present itself - if you have a ForeignKey you're setting manually, wouldn't you use exclude to hide it from the form entirely, so it is therefore not being set at all in save() ?

[omat@…]

You are right, FK should be excluded from start.

[Jacob]

Milestone 1.0 deleted