Django

Code

Ticket #7575 (closed: fixed)

Opened 5 months ago

Last modified 4 months ago

Peruvian departments are now regions

Reported by: andresj Assigned to: nobody
Milestone: 1.0 beta Component: django.contrib.localflavor
Version: SVN Keywords: pe l10n
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Recently, I think in 2007, Peru switched over to regions. This affects django.contrib.localflavor.pe.PEDepartmentSelect, which should be renamed to PERegionSelect. Also, the Callao Region should be added. (See http://en.wikipedia.org/wiki/Administrative_divisions_of_Peru.)

Another issue, although related to this change, is that the Province of Lima (which is separate from Lima Region) is not part of any Region. This is similar to the U.S., where Washington D.C. is independent from other states. The difference is that more than one third of Peru's population lives in the Lima and Callao Metropolitan Area.

The proposed solution is to create a PEDivisonSelect (and, subsequently, a USDivisionSelect), which include all top-level divisions of the countries. Note that, for example, USStateSelect includes Puerto Rico, which is not a state, but a commonwealth. (http://en.wikipedia.org/wiki/Puerto_Rico#Within_the_United_States). It would be included in USDivisionSelect.

Attachments

django-peruvian-regions.patch (3.0 kB) - added by andresj on 06/30/08 11:50:50.
Changed Peruvian Departments to Regions and added Callao.
7575.diff (3.2 kB) - added by programmerq on 07/19/08 14:49:19.
Patch applies cleanly to trunk

Change History

06/30/08 11:50:50 changed by andresj

  • attachment django-peruvian-regions.patch added.

Changed Peruvian Departments to Regions and added Callao.

07/18/08 19:18:52 changed by Simon Greenhill

  • needs_better_patch changed.
  • needs_tests changed.
  • milestone set to 1.0 beta.
  • keywords set to pe l10n.
  • needs_docs changed.
  • stage changed from Unreviewed to Ready for checkin.

07/19/08 14:40:55 changed by mtredinnick

  • needs_better_patch set to 1.
  • stage changed from Ready for checkin to Accepted.

I don't understand how a patch that cannot be applied can be marked as "ready for checkin". This patch patches a non-existent file. Could triagers please be careful when changing the ticket states.

Patch needs improvement so that it applies to trunk before it can go in.

07/19/08 14:49:19 changed by programmerq

  • attachment 7575.diff added.

Patch applies cleanly to trunk

07/19/08 14:49:42 changed by programmerq

  • needs_better_patch deleted.
  • stage changed from Accepted to Ready for checkin.

This should work correctly.

08/08/08 10:34:07 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [8230]) Fixed #7575 -- Peru now has regions, not departments (changed at some pointi n the last year or so). Thanks andresj and programmerq.

This is backwards incompatible if you're using the Peruvian localflavor.


Add/Change #7575 (Peruvian departments are now regions)




Change Properties
Action