Django

Code

Ticket #7568 (closed: wontfix)

Opened 5 months ago

Last modified 5 months ago

Pep8 Style Code In Newforms

Reported by: stevemilner Assigned to: nobody
Milestone: 1.0 beta Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Running pep8 code checker against newforms yields a lot of output. I've attached a patch that helps start the move closer to pep8 (patch -p1 < 0001-started-to-move-newforms-closer-to-pep8-standards.diff).

Attachments

0001-started-to-move-newforms-closer-to-pep8-standards.diff (30.2 kB) - added by stevemilner on 06/29/08 15:53:56.

Change History

06/29/08 15:53:56 changed by stevemilner

  • attachment 0001-started-to-move-newforms-closer-to-pep8-standards.diff added.

06/29/08 18:45:38 changed by mtredinnick

  • status changed from new to closed.
  • needs_better_patch changed.
  • resolution set to wontfix.
  • needs_tests changed.
  • needs_docs changed.

Thanks, but no thanks. A bunch of these changes are actually bad style (for example, splitting imports from a single model over multiple lines). Yes, there are a lot of lines in Django that are longer than 79 characters. Life's like that sometimes. It's not insurmountable and when we edit the code for other reasons, they'll sometimes be cleaned up.

It's more useful to have accurate annotation information on the lines of code so that we can see when they were last changed for a good reason (rather than just stylistic editing) and including this patch would remove that information from the "annotate" command in any version control system. That's a big minus when debugging.

Add/Change #7568 (Pep8 Style Code In Newforms)




Change Properties
Action