Django

Code

Ticket #7532 (closed: fixed)

Opened 5 months ago

Last modified 5 months ago

limit_offset_sql DatabaseOperations method deprecated?

Reported by: ramiro Assigned to: nobody
Milestone: Component: Database layer (models, ORM)
Version: SVN Keywords: db-be-api limit offset limit_offset_sql
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Seems that since qs-rf landing other means are now employed to handle LIMIT/OFFSET SQL query components construction and limit_offset_sql() isn't used anymore from anywhere in the Django source tree.

Attached is a patch (against r7732) that drops it.

See also #7319

Attachments

no_limit_offset_sql_r7732.diff (2.7 kB) - added by ramiro on 06/24/08 05:49:09.

Change History

06/24/08 05:49:09 changed by ramiro

  • attachment no_limit_offset_sql_r7732.diff added.

06/24/08 05:50:20 changed by ramiro

  • needs_better_patch changed.
  • component changed from Uncategorized to Database wrapper.
  • needs_tests changed.
  • needs_docs changed.

06/25/08 05:04:37 changed by Bastian Kleineidam <calvin@debian.org>

Yep, limit_offset_sql() is dead code.

06/25/08 11:38:12 changed by ramiro

  • keywords changed from limit offset limit_offset_sql to db-be-api limit offset limit_offset_sql.

07/06/08 09:26:37 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7852]) Fixed #7532 -- Removed some dead code from the db backends. Thanks, Ramiro.

Add/Change #7532 (limit_offset_sql DatabaseOperations method deprecated?)




Change Properties
Action