Django

Code

Ticket #7502 (closed: fixed)

Opened 6 months ago

Last modified 6 months ago

Changeset 7694 breaks I18N translation

Reported by: frasern Assigned to: nobody
Milestone: 1.0 alpha Component: django.contrib.admin
Version: newforms-admin Keywords: nfa
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

It looks like part of the change made in in [7694] will inadvertently break I18N translation.

I think 

	                        message = _("Your e-mail address is not your username." 
	                                    " Try '%s' instead." % user.username)

should probably be 

	                        message = _("Your e-mail address is not your username." 
	                                    " Try '%s' instead.") % user.username

so that the string substitution is done after the translated version of the text is loaded. Otherwise there would have to be a translated version of this string for every possible username.

Attachments

7502.diff (0.7 kB) - added by arien on 06/20/08 01:53:48.
patch as per description

Change History

06/19/08 04:11:32 changed by telenieko

  • needs_better_patch changed.
  • needs_tests changed.
  • milestone set to 1.0 alpha.
  • keywords set to nfa.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

06/20/08 01:53:48 changed by arien

  • attachment 7502.diff added.

patch as per description

06/20/08 01:54:43 changed by arien

  • has_patch set to 1.
  • version changed from SVN to newforms-admin.

06/20/08 02:40:46 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7711]) newforms-admin: Fixed #7502 -- Fixed an i18n breakge introduced in [7694]. Thanks frasern.

Add/Change #7502 (Changeset 7694 breaks I18N translation)




Change Properties
Action