Django

Code

Ticket #7458 (closed: fixed)

Opened 6 months ago

Last modified 6 months ago

Lithuanian translation

Reported by: Rapolas Assigned to: nobody
Milestone: Component: Translations
Version: SVN Keywords: lithuanian lt translation l10n
Cc: Rapolas Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Attachments

django.po (76.5 kB) - added by Rapolas@gmail.com on 06/15/08 06:17:12.
Lithuanian translation
djangojs.po (3.2 kB) - added by Rapolas on 06/15/08 14:05:55.
Lithuanian translation

Change History

06/15/08 06:17:12 changed by Rapolas@gmail.com

  • attachment django.po added.

Lithuanian translation

06/15/08 12:12:58 changed by telenieko

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

Are you willing to mantain Lithuanian in the future if this goes in? Translations need constant mainteinance.

(follow-up: ↓ 3 ) 06/15/08 12:26:45 changed by garcia_marc

  • cc set to Rapolas.
  • keywords set to lithuanian lt translation l10n.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.
  • needs_better_patch set to 1.

First of all, thanks for the translation. You couldn't have a EuroPython? without it... ;)

I've to comment some things about the patch:

Translation of djangojs.po is missing. And also are missing both translation compiled files (.mo).

Also for Django's policy, you should remove your name from the .po files, and add it at the end of authors file.

Finally, the correct way to submit a patch, is posting the result of a "svn diff" from your django root. It'll include all the changes you made.

(in reply to: ↑ 2 ) 06/15/08 12:59:57 changed by telenieko

Replying to garcia_marc:

Also for Django's policy, you should remove your name from the .po files, and add it at the end of authors file.

Not really, Malcolm usually compiles the .mo's to make sure .po == .mo

06/15/08 14:05:55 changed by Rapolas

  • attachment djangojs.po added.

Lithuanian translation

(follow-up: ↓ 5 ) 06/15/08 14:14:14 changed by Rapolas

Ok, I added djangojs.po file. As I understood from telenieko I don't need to make .mo files, correct me if I'm wrong ;) And I didn't get it, how to submit a patch, after doing svn diff, I got binary file, which posting here would be nonsense. Maybe I did something wrong... By the way thanks for telling about EuroPython?, I would missed it;) And one more thing about maintaining, yes, I can do that, at least for now.

(in reply to: ↑ 4 ) 06/15/08 14:19:07 changed by telenieko

  • needs_better_patch deleted.
  • stage changed from Accepted to Ready for checkin.

Replying to Rapolas:

Ok, I added djangojs.po file. As I understood from telenieko I don't need to make .mo files

No worry ,they'll be compiled before commit.

how to submit a patch, after doing svn diff, I got binary file, which posting here would be nonsense. Maybe I did something wrong...

Sure, when you run svn diff you get the differences between your working copy nd the tree, given that you are diffing text files, you can't get binary differences. Maybe you are getting a text diff for the .po and a binary blob for the .po

Given it's a new translation there's not much problem on attaching .po files directly but for updates, try to do the svn diff after deleting the .mo to avoid having them in the diff.

And one more thing about maintaining, yes, I can do that, at least for now.

Thanks.

06/15/08 14:23:59 changed by telenieko

Oh, forgot to tell, try to join Django-i18n first step when contributing translations!

You'll se on those instructions that it's better to do the diff before checking the compile, to avoid the binary blob ;)

06/18/08 15:38:35 changed by telenieko

(In [7695]) Refs #7458, New Lithuanian translation. Thanks Rapolas Kaselis.

06/18/08 15:53:55 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [7698]) Fixed #7458: added Lithuanian to LANGUAGES.

Add/Change #7458 (Lithuanian translation)




Change Properties
Action