Django

Code

Ticket #7429 (closed: fixed)

Opened 6 months ago

Last modified 6 months ago

Make SessionBase more dictionary-like

Reported by: jdunck Assigned to: nobody
Milestone: Component: django.contrib.sessions
Version: SVN Keywords:
Cc: davidgouldin@pegasusnews.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

SessionBase? is missing the following dictionary methods: 

>>> engine = __import__(settings.SESSION_ENGINE, {}, {}, [''])
>>> session = engine.SessionStore(None)
>>> set(dir(dict)) - set(dir(session))
set(['__ne__', '__ge__', 'fromkeys', '__eq__', 'clear', '__gt__', 'update', '__cmp__', '__le__', '__iter__', 'has_key', 'values', 'iterkeys', 'itervalues', 'iteritems', '__lt__', 'copy', 'popitem', '__len__'])

This patch adds support for update, has_key, values, iterkeys, itervalues, and iteritems.

Includes tests.

Attachments

session-dictlike.diff (2.4 kB) - added by jdunck on 06/11/08 18:18:03.
As of Django svn 7543.
session-dictlike.2.diff (2.4 kB) - added by jdunck on 06/11/08 18:43:36.
Fixed .update to take **kwargs.

Change History

06/11/08 18:18:03 changed by jdunck

  • attachment session-dictlike.diff added.

As of Django svn 7543.

06/11/08 18:20:03 changed by jdunck

  • cc set to davidgouldin@pegasusnews.com.

06/11/08 18:43:36 changed by jdunck

  • attachment session-dictlike.2.diff added.

Fixed .update to take **kwargs.

06/14/08 07:22:07 changed by Simon Greenhill

  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.

06/18/08 07:09:41 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [7687]) Fixed #7429 -- Modified the Session base class a little more dictionary-like by adding update(), has_key(), values(), and iterator access methods. Thanks to Jeremy Dunck for the suggestion and patch.

Add/Change #7429 (Make SessionBase more dictionary-like)




Change Properties
Action