Opened 16 years ago
Closed 13 years ago
#7399 closed New feature (wontfix)
Allow Google's AppEngine Memcache library.
Reported by: | Adam Blinkinsop | Owned by: | nobody |
---|---|---|---|
Component: | Core (Cache system) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Google's AppEngine contains a modification of the Memcache library that is functionally compatible.
Several changes would make it easy to drop this into the existing cache system. One possibility is adding it to the try/except block at the top of [source:trunk/django/core/cache/backends/memcached.py django.core.cache.backends.memcached]. There could also be a setting that determines which library to use (like the TEMPLATE_LOADERS or MIDDLEWARE_CLASSES settings). Which is more Django-friendly?
Even if this doesn't need to be in trunk, I think that it would be useful to have an easy way to add a new memcache interface, and it seems like a violation of DRY to create a new backends module for something so compatible. Thoughts?
Attachments (1)
Change History (8)
by , 16 years ago
Attachment: | memcache.patch added |
---|
comment:1 by , 16 years ago
Has patch: | set |
---|---|
Needs documentation: | set |
Triage Stage: | Unreviewed → Accepted |
Needs a mention in the caching docs, but otherwise sounds like a fine idea.
follow-up: 3 comment:2 by , 16 years ago
Triage Stage: | Accepted → Design decision needed |
---|
This trick is too implicit and unintuitive. Specifying Google memcached explicit is more pythonic. I think #7398 is better way to implement this.
follow-up: 4 comment:3 by , 16 years ago
Replying to anonymous:
This trick is too implicit and unintuitive. Specifying Google memcached explicit is more pythonic. I think #7398 is better way to implement this.
I agree; how do we influence the design of #7398 so that we can use the existing backend with the new google.appengine.api.memcache
module?
comment:4 by , 16 years ago
comment:5 by , 16 years ago
I have posted a modified version of memcache.py that, in correlation with #7398, explicitly uses Google's memcache as the cache backend.
comment:6 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → New feature |
comment:7 by , 13 years ago
Easy pickings: | unset |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
UI/UX: | unset |
Closing as wontfix since nowadays it's rather easy to subclass BaseMemcachedCache
that was added in r15005
(source:django/trunk/django/core/cache/backends/memcached.py?rev=16001#L9) similar the default Memcache class (source:django/trunk/django/core/cache/backends/memcached.py?rev=16001#L146)
A patch that adds Google's memcache library to the memcached module.