Django

Code

Ticket #7378 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

Reverse relationship ignores to_field (in another setting)

Reported by: mturtle@gmail.com Assigned to: jacob
Milestone: 1.0 Component: Database layer (models, ORM)
Version: SVN Keywords: qsrf-cleanup
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

This is related to bug #4510. I am using the latest version from SVN (r7574), and a similar error is happening. Basically, the reverse relationship ignores the to_field when I use it directly as a property (although the example in #4510 using it in a filter works fine).

If I have these models:

class Place(models.Model):
    unique_but_not_primary_field = models.IntegerField(unique=True)

class Franchise(models.Model):
    place = models.ForeignKey(Place, to_field='unique_but_not_primary_field')

And I enter this code:

>>> new_york = Place(unique_but_not_primary_field=1000)
>>> new_york.save()
>>> mcdonalds = Franchise()
>>> mcdonalds.place = new_york
>>> mcdonalds.save()
>>> print new_york.franchise_set.all()
[]
>>> print django.db.connection.queries[-1]['sql']
SELECT `cms_franchise`.`id`, `cms_franchise`.`place_id` FROM `cms_franchise` INNER JOIN `cms_place` ON (`cms_franchise`.`place_id` = `cms_place`.`unique_but_not_primary_field`) WHERE `cms_place`.`id` = 1000 

It is still doing the join on the primary key, not the to_field.

As far as I can tell, the problem is in django/db/models/fields/related.py on line 322:

manager.core_filters = {'%s__pk' % rel_field.name: getattr(instance, rel_field.rel.get_related_field().attname)}

I changed this line to the following, and it works perfectly for me:

manager.core_filters = {'%s__%s' % (rel_field.name, rel_field.rel.get_related_field().attname): getattr(instance, rel_field.rel.get_related_field().attname)}

Attachments

Change History

06/08/08 12:51:43 changed by jacob

  • owner changed from nobody to jacob.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

06/10/08 09:20:50 changed by gav

  • keywords set to qsrf-cleanup.

06/16/08 12:10:45 changed by jacob

  • milestone set to 1.0.

06/29/08 05:35:35 changed by mtredinnick

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7785]) Fixed #7378 -- Use the "to_field" where appropriate on reverse relations.

Patch from mturtle@gmail.com. The remaining uses of "%spk" in fields/related.py all look safe, since they are for many-to-many fields, which doesn't take "to_field" as a parameter.


Add/Change #7378 (Reverse relationship ignores to_field (in another setting))




Change Properties
Action