Django

Code

Ticket #724 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

get_next_by_pub_date/get_previous_by_pub_date model methods only see 1 item for each day.

Reported by: mattycakes@gmail.com Assigned to: adrian
Milestone: Component: Core framework
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The model.get_next_by_pub_date() and model.get_previous_by_pub_date() methods appear to only see one item for each day.

For example, I have a blog.posts model in which pub_date is a DateTimeField?. If there are multiple posts in one day, the above methods will only see the first post for each day, and then skip to the next day. This is clearly wrong behaviour; the method should retrieve the next item by date whether it was created the same day or not.

Example: 

item1.pub_date = 2005/01/01 12:00
item2.pub_date = 2005/01/02 8:00
item3.pub_date = 2005/01/02 9:00

item1.get_next… = item2
item2.get_next… = None
item3.get_prev… = item1

Attachments

lookup_patch.txt (0.5 kB) - added by mattycakes@gmail.com on 11/09/05 19:57:05.
Patch to lookup API tests

Change History

11/04/05 00:28:42 changed by mattycakes@gmail.com

  • severity changed from major to minor.

In fact, it only has this problem if multiple items have the same time as well as the same date.

Example: 

item1.pub_date = 2005/01/01 12:00
item2.pub_date = 2005/01/02 8:07
item3.pub_date = 2005/01/02 8:07

item1.get_next… = item2
item2.get_next… = None
item3.get_prev… = item1

The above is valid; my first example, however, is wrong.

11/09/05 18:04:28 changed by adrian

  • status changed from new to closed.
  • resolution set to invalid.

In [1152] I added some unit tests for this. I can't recreate the problem -- the tests run fine. Please reopen with more information on how to recreate the bug.

11/09/05 19:56:09 changed by mattycakes@gmail.com

  • status changed from closed to reopened.
  • resolution deleted.

I've added a few tests. Hopefully these help clarify the problem. 

Index: tests/testapp/models/lookup.py
===================================================================
--- tests/testapp/models/lookup.py	(revision 1154)
+++ tests/testapp/models/lookup.py	(working copy)
@@ -103,4 +103,16 @@
 Article 4
 >>> a5.get_previous_by_pub_date()
 Article 6
+>>> a4.get_previous_by_pub_date()
+Article 3
+>>> a3.get_previous_by_pub_date()
+Article 2
+>>> a2.get_previous_by_pub_date()
+Article 1
+>>> a1.get_next_by_pub_date()
+Article 2
+>>> a2.get_next_by_pub_date()
+Article 3
+>>> a3.get_next_by_pub_date()
+Article 4
 """

11/09/05 19:57:05 changed by mattycakes@gmail.com

  • attachment lookup_patch.txt added.

Patch to lookup API tests

11/09/05 23:36:42 changed by adrian

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [1155]) Fixed #724 -- Ensured get_next_by_FOO() and get_previous_by_FOO() methods don't skip or duplicate any records in the case of duplicate values. Thanks for reporting the bug, mattycakes@gmail.com

Add/Change #724 (get_next_by_pub_date/get_previous_by_pub_date model methods only see 1 item for each day.)




Change Properties
Action