Django

Code

Ticket #7230 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

No save_m2m method on BaseModelFormSet or BaseInlineFormSet

Reported by: brooks.travis@gmail.com Assigned to: brosner
Milestone: 1.0 alpha Component: Forms
Version: newforms-admin Keywords: nfa-blocker
Cc: cmawebsite@gmail.com Triage Stage: Accepted
Has patch: 1 Needs documentation: 1
Needs tests: 1 Patch needs improvement: 0

Description

There is currently no similar method to ModelForm?'s save_m2m for saving m2m relationship data after a save(commit=False) on a BaseModelFormSet? or BaseInlineFormSet?.

Attachments

7230_formset_save_m2m.diff (1.5 kB) - added by brosner on 06/19/08 21:38:41.

Change History

05/13/08 16:13:24 changed by brosner

  • status changed from new to assigned.
  • needs_better_patch changed.
  • needs_tests changed.
  • owner changed from nobody to brosner.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

This makes sense. [7507] made save() on a model formset only return changed instances. That logic should be abstracted out. Providing a save_m2m() on the BaseModelFormSet would make alot of sense.

06/19/08 21:38:41 changed by brosner

  • attachment 7230_formset_save_m2m.diff added.

06/19/08 21:39:20 changed by brosner

  • needs_docs set to 1.
  • has_patch set to 1.
  • needs_tests set to 1.
  • milestone set to 1.0 alpha.

Attached a patch, but need to add some tests and documentation.

06/27/08 09:54:35 changed by garcia_marc

  • keywords set to nfa-blocker.

I add nfa-blocker keyword as synonym of 1.0 alpha milestone (just for organization).

07/05/08 08:03:01 changed by CollinAnderson

  • cc set to cmawebsite@gmail.com.

07/15/08 17:41:18 changed by brosner

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7930]) newforms-admin: Fixed #7230 -- Added a save_m2m method to BaseModelFormSet? when commit=False is passed to save. Thanks Books Travis for the original report.

Add/Change #7230 (No save_m2m method on BaseModelFormSet or BaseInlineFormSet)




Change Properties
Action