Django

Code

Ticket #7160 (closed: fixed)

Opened 1 week ago

Last modified 1 week ago

MultiWidget does not detect changed values on an Inline - newforms-admin

Reported by: mwdiers <martin@diers.us> Assigned to: brosner
Component: Admin interface Version: newforms-admin
Keywords: newforms-admin multiwidget inline Cc:
Triage Stage: Accepted Has patch: 0
Needs documentation: 0 Needs tests: 0
Patch needs improvement: 0

Description

Initial values saved via a MultiWidget? in an Inline form in the admine, are saved properly. Subsequent changes to an existing record are not saved. I discovered this with my own MultiWidget?, but tested it with a SplitDateTimeField? as well.

To reproduce, place a DateTimeField? into any Inline model. Save a new record. Works. Change that record. Doesn't work.

Attachments

Change History

05/05/08 12:20:20 changed by anonymous

  • needs_better_patch changed.
  • version changed from SVN to newforms-admin.
  • needs_tests changed.
  • needs_docs changed.

05/05/08 12:21:47 changed by brosner

  • owner changed from nobody to brosner.
  • status changed from new to assigned.

Last one was me. I will look into this.

05/05/08 12:57:50 changed by brosner

  • stage changed from Unreviewed to Accepted.

I've narrowed this down to a problem in the MultiWidget?._has_changed method. Poor test coverage didn't catch this error. Will have this fixed shortly.

05/05/08 13:08:07 changed by brosner

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7517]) newforms-admin: Fixed #7160 -- MultiWidget?._has_changed was short-circuiting while testing for changed data in its widgets. Added tests to ensure this won't get broken in the future.

Add/Change #7160 (MultiWidget does not detect changed values on an Inline - newforms-admin)




Change Properties
Action