Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#709 closed defect (fixed)

The MultiValueDict in datastructures.py should have a "__contains__" method defined

Reported by: brantley (deadwisdom@… Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The MultiValueDict in datastructures.py should have a "contains" method defined, so that one can do:

if ('world' in request.GET):
    destroy_world(request.GET['world'])

Although, the destroy_world function is left as an exercise for the reader.

A simple patch which concerns datastructures.py is included.

Attachments (1)

datastructures.diff​ (431 bytes ) - added by brantley (deadwisdom@… 19 years ago.

Download all attachments as: .zip

Change History (7)

by brantley (deadwisdom@…, 19 years ago

Attachment: datastructures.diff​ added

comment:1 by anonymous, 19 years ago

Type: enhancement → defect

what is holding back implementing this fix in trunk? I keep running into this bug. I changed it to a defect.

comment:2 by Adrian Holovaty, 19 years ago

I've been waiting for an implementation of the destroy_world function.

comment:3 by Adrian Holovaty, 19 years ago

Resolution: → fixed
Status: new → closed

(In [1498]) Fixed #709 -- Added a contains method to MultiValueDict. Thanks, Brantley

comment:4 by django@…, 19 years ago

destroy_world is implemented in #736.

comment:5 by Adrian Holovaty, 19 years ago

Coincidentally, I'm working on that patch right now. :)

comment:6 by kevin stone, 19 years ago

bien, gracious.

Note: See TracTickets for help on using tickets.
Back to Top