Django

Code

Ticket #7068 (closed: fixed)

Opened 2 months ago

Last modified 2 months ago

contrib.auth.forms are not i18n enabled

Reported by: pigletto Assigned to: nobody
Milestone: Component: Contrib apps
Version: newforms-admin Keywords: password auth reset
Cc: pigletto@gmail.com Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

AuthenticationForm, PasswordResetForm, PasswordChangeForm, AdminPasswordChangeForm have no 'label' set for it's fields, eg.: 

password1 = forms.CharField(max_length=60, widget=forms.PasswordInput)

so field labels are not internationalized. Patch is attached.

Would be nice if this can be applied with ticket 6905 http://code.djangoproject.com/ticket/6905.

Attachments

auth_translations_v7436.diff (2.2 kB) - added by pigletto on 04/23/08 01:26:18.
patch against svn version 7436

Change History

04/23/08 01:26:18 changed by pigletto

  • attachment auth_translations_v7436.diff added.

patch against svn version 7436

04/23/08 01:35:23 changed by Alex

  • needs_better_patch changed.
  • stage changed from Unreviewed to Fixed on a branch.
  • needs_tests changed.
  • needs_docs changed.

This has been fixed in the newforms-admin branch

04/23/08 01:53:55 changed by pigletto

Sorry but where is that fix? I can't see it fixed at newforms-admin branch, revision 7442:

http://code.djangoproject.com/browser/django/branches/newforms-admin/django/contrib/auth/forms.py?rev=7442

04/23/08 02:07:16 changed by Alex

  • stage changed from Fixed on a branch to Accepted.

Whoops, boneheaded move on my part, it looks like those are only set on one of the forms(user creation).

04/23/08 11:02:25 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7449]) newforms-admin: Fixed #6774, #7068 -- Use ugettext_lazy instead of ugettext in django/contrib/auth/forms.py. Marked a few strings for translation in the forms.

Add/Change #7068 (contrib.auth.forms are not i18n enabled)




Change Properties
Action