Django

Code

Ticket #7033 (closed: fixed)

Opened 4 months ago

Last modified 2 months ago

Dead code: OrderingField

Reported by: julien Assigned to: nobody
Milestone: Component: Uncategorized
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

As discussed in [1], there's a piece of code (OrderingField? class in django.db.models.fields) that seems to be dead and should be considered to be removed.

[1] http://groups.google.com/group/django-users/browse_thread/thread/78669fdb8790ca3d/20fcd8384493610a#20fcd8384493610a

Attachments

remove_unused_OrderField.diff (0.9 kB) - added by anonymous on 06/25/08 09:10:09.
Patch removing the dead code

Change History

06/14/08 06:51:31 changed by Simon Greenhill

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

06/25/08 09:10:09 changed by anonymous

  • attachment remove_unused_OrderField.diff added.

Patch removing the dead code

06/30/08 02:10:04 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7794]) Fixed #7033 -- Removed an unused field.

OrderingField? was added in the magic-removal branch to support something that never ultimately materialised, but it wasn't removed. So this is backwards-incompatible if you're using this field that has no purpose, I guess.

Add/Change #7033 (Dead code: OrderingField)




Change Properties
Action