Django

Code

Ticket #7011 (new)

Opened 3 months ago

Last modified 1 month ago

Authentication documentation doesn't describe is_active very well.

Reported by: mtredinnick Assigned to: nobody
Milestone: Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The documentation for the User class in the authentication docs doesn't describe the effect of the is_active flag. It could easily lead people to suspect that the flag enforces whether the person can log in, however it is just a flag and the user's code needs to check it when determining whether to grant the user access to things. Nothing in the User model or login path enforces is_active (which is a good thing), although permission checking does respect it (useful for things doing model-level permission checking).

I'm not going to fix this now, since the documentation directory is undergoing churn at the moment whilst Jacob refactors it. This should wait until after that is finished.

Attachments

Change History

04/12/08 20:50:31 changed by mtredinnick

(In [7414]) Updated the inline help text for User.is_active.

Fixed #6881. Refs #7011.

06/15/08 01:39:03 changed by Simon Greenhill

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

06/15/08 08:23:30 changed by telenieko

  • has_patch deleted.
  • stage changed from Ready for checkin to Accepted.

Why Ready for checkin? There's no patch attached and even malcolm said he's not going to fix this now.


Add/Change #7011 (Authentication documentation doesn't describe is_active very well.)




Change Properties
Action