Opened 18 years ago

Closed 11 years ago

#6992 closed Cleanup/optimization (fixed)

Better error message if Middleware.process_response returns None

Reported by: Thomas Güttler Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: hv@… Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It is easy to forget the return statement in process_response(). This
little patch results in a better error message.

Attachments (1)

6992.diff​ (701 bytes ) - added by Thomas Güttler 18 years ago.

Download all attachments as: .zip

Change History (8)

by Thomas Güttler, 18 years ago

Attachment: 6992.diff​ added

comment:1 by Marc Fargas, 17 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Chris Beaven, 16 years ago

Patch needs improvement: set

Error message is a wee bit confusing (and is the wsgi handler isn't the only place where this is needed - maybe a small refactor would be good).

comment:3 by Julien Phalip, 15 years ago

Severity: → Normal
Type: → Cleanup/optimization

comment:4 by Aymeric Augustin, 14 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:5 by Aymeric Augustin, 14 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:6 by Aymeric Augustin, 11 years ago

Has patch: unset
Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

PR: ​https://github.com/django/django/pull/2774

It's quite simple but I'll wait for the CI to run the test suite.

comment:7 by Aymeric Augustin <aymeric.augustin@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 47a9347b9828ed0186d676ee0c5cadd9e6a93edb:

Fixed #6992 -- Improved error when middleware omits HttpResponse.

Thanks guettli for the report.

Note: See TracTickets for help on using tickets.
Back to Top