Django

Code

Ticket #6903 (new)

Opened 8 months ago

Last modified 4 months ago

Go back to old change_list view after hitting save

Reported by: jarrow Assigned to: nobody
Milestone: post-1.0 Component: django.contrib.admin
Version: newforms-admin Keywords: nfa-someday yandex-sprint
Cc: Triage Stage: Design decision needed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description (Last modified by ramiro)

When editing something via the admin I could observe a recurring usage pattern on myself:

  1. Search for something (e.g. by time, filter, phrase) wanting to edit them all or just go through the pages till I found a certain timespan
  2. Edit
  3. Hit save
  4. Hit the back button two times to get my former list
  5. Repeat with 2. :)

While this may be ok for myself my client is protesting ;) So I thought I'll hack it. But then again, isn't the desired behaviour to go back to the exact collection of stuff in the change list that was there before anyway?

So I'd like to propose to change that. I'm happy to try and write a patch for it, if this get's accepted.

Cheers!

Jonas

Attachments

return_to_old_change_list.diff (4.8 kB) - added by slonopotamus on 07/12/08 09:13:58.

Change History

03/27/08 09:19:06 changed by Karen Tracey <kmtracey@gmail.com>

  • keywords set to nfa-someday.
  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

This has been requested before, see for example #3777. That was closed by submitter after an alternate method was shown that didn't involve changing Django code. I haven't tried it so don't know if it's still directly applicable to newforms-admin but it might give you an idea of an approach.

03/27/08 09:35:34 changed by jarrow

Ah, I'll look into the patch. Thx! I still think this should be the default behaviour. The question ist: Why wouldn't I want the filters to be persistent? IMHO the user expects this and not the automatic filter reset. Any thoughts?

03/27/08 11:33:02 changed by Karen Tracey <kmtracey@gmail.com>

I agree that preserving the filters is more user-friendly. Personally it doesn't bother me too much in Django admin but that's because I don't happen to use filters in admin that much. However when I run into it in other interfaces it tends to annoy me when some sort of item-edit page's "doit" button returns me to a list that differs from the one I came from to edit the object. So I'd be in favor of the change, but don't have much personal interest in it and think newforms-admin has bigger fish to fry at the moment (specifically anything blocking a merge to trunk).

06/16/08 16:12:38 changed by ramiro

  • description changed.

07/12/08 09:13:27 changed by slonopotamus

  • owner changed from nobody to slonopotamus.
  • has_patch set to 1.

07/12/08 09:13:58 changed by slonopotamus

  • attachment return_to_old_change_list.diff added.

07/12/08 09:14:23 changed by slonopotamus

  • owner changed from slonopotamus to nobody.

07/14/08 02:08:10 changed by slonopotamus

  • keywords changed from nfa-someday to nfa-someday yandex-sprint.

08/18/08 10:40:09 changed by ericholscher

  • milestone set to post-1.0.

Add/Change #6903 (Go back to old change_list view after hitting save)




Change Properties
Action