Ticket Navigation

Ticket #6893 (closed: fixed)

Opened 8 months ago

Last modified 3 months ago

FormWizard does not set the step value correctly

Reported by:	siddhi	Assigned to:	anonymous
Milestone:	1.0	Component:	django.contrib.formtools
Version:	SVN	Keywords:	form wizard formtools contrib
Cc:	join.together@gmail.com, newijk@gmail.com, v.oostveen@gmail.com, adam@sitedesign.net, mpjung@terreon.de, philipp@igowo.de, rokclimb15@gmail.com, bthomas@ncircle.com	Triage Stage:	Accepted
Has patch:	1	Needs documentation:	0
Needs tests:	0	Patch needs improvement:	0

Description

The FormWizard class in django.contrib.formtools.wizard has a method called get_template which can be overridden to return a template for each step of the form submission process. This get_template method gets the step value as a parameter. However, no matter what step of the form processing we are in, this parameter is always 0.

The step value everywhere else is either computed dynamically or passed as a parameter. Only the get_template call uses self.step which is initialised to 0 and then never set again as we move through the steps.

The patch contains two fixes:

The call to get_template uses the step that is passed as a parameter (and has the correct value) instead of using self.step
self.step is updated at the end of processing

The patch also contains two test cases to check this. One of the tests should fail with the old code. Both tests should pass with the patched code.

As an aside, self.step is now used only in the repr method, so maybe it can be removed from there and then removed entirely from the FormWizard? class?

Attachments

form_wizard_patch.diff (3.4 kB) - added by siddhi on 03/26/08 05:27:41.: Patch for the code and test cases for this bug
form_wizard_patch_2.diff (3.3 kB) - added by wamberg on 08/01/08 14:02:14.: Updated patch to r8172

Change History

05/02/08 09:11:52 changed by trbs

cc changed from join.together@gmail.com to join.together@gmail.com, v.oostveen@gmail.com.

Also hit this problem today and the patch looks fine to me.

At this moment, I've written a decorator for the formwizard.render_template method to inject the assignment of the self.step variable. The code below is just a HACK and is by no means a permanent solution.

## Hack in FormWizard until django ticket #6893 is solved
def formwizard_render_template_decorator(func):
    def inject_assign_step(klass, request, form, previous_fields, step, *args, **kwargs):
        klass.step = step
        return func(klass, request, form, previous_fields, step, *args, **kwargs)
    return inject_assign_step

FormWizard.render_template = formwizard_render_template_decorator(FormWizard.render_template)

If you want to use this hack note two important things:

This should only be applied once ! (thus not per FormWizard? (sub)class definition)
It must be removed after a fix is made !

I've only added this to the comments for people that do not like to patch the django installation there running. But like said above this does require you to remember to remove it when a solution/patch hits django trunk.

Add/Change #6893 (FormWizard does not set the step value correctly)

Your email or username:

Comment (you may use WikiFormatting here):

Change Properties

Summary:
Milestone:		Component:
Version:		Keywords:
Cc:		Triage Stage:
Has patch:		Needs documentation:
Needs tests:		Patch needs improvement:

Action leave as closed
reopen ticket

Download in other formats:

Code

Ticket Navigation

Ticket #6893 (closed: fixed)

FormWizard does not set the step value correctly

Description

Attachments

Change History

03/26/08 05:27:41 changed by siddhi

04/18/08 11:17:12 changed by anonymous

05/02/08 09:11:52 changed by trbs

05/06/08 05:56:39 changed by anonymous

06/14/08 06:42:30 changed by telenieko

07/02/08 02:09:36 changed by dan90

07/02/08 02:18:20 changed by dan90

07/07/08 14:39:35 changed by anonymous

07/15/08 17:10:31 changed by Michael P. Jung

07/21/08 05:15:50 changed by anonymous

07/29/08 15:11:19 changed by philwo

08/01/08 14:02:14 changed by wamberg

08/03/08 18:27:27 changed by kmtracey

08/08/08 10:45:19 changed by mcroydon

08/08/08 13:01:01 changed by mcroydon

08/11/08 17:32:42 changed by anonymous

08/18/08 16:19:19 changed by bthomas

08/20/08 14:39:22 changed by anonymous

08/26/08 16:33:56 changed by jacob

Add/Change #6893 (FormWizard does not set the step value correctly)

Download in other formats: