Django

Code

Ticket #6852 (closed: fixed)

Opened 9 months ago

Last modified 8 months ago

DeprecationWarning in admin, caused by recent changes to pagination

Reported by: nickefford Assigned to: nobody
Milestone: Component: django.contrib.admin
Version: SVN Keywords: admin,pagination
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation:
Needs tests: Patch needs improvement:

Description

The admin app uses the old ObjectPaginator class, which triggers DeprecationWarning as of [7306]. The attached patch, against trunk, tweaks admin to use the new API. It seems to work OK as far I as can see, but wiser heads than mine will need to verify :)

Note that this is against trunk, not newforms-admin, as the latter hasn't merged in the new pagination code yet.

Feel free to wontfix if you think we can live with warnings until newforms-admin arrives. In any case, the patch might be useful to newforms-admin devs as the basis of a proper, long-term solution.

Attachments

admin_pagination.diff (3.9 kB) - added by nickefford on 03/21/08 07:40:05.
Fixes to pagination code of admin app

Change History

03/21/08 07:40:05 changed by nickefford

  • attachment admin_pagination.diff added.

Fixes to pagination code of admin app

03/25/08 00:20:55 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [7363]) Fixed #6852 -- Converted the admin to use the new paginator, to remove DeprecationWarnings?. Thanks for the patch, nickefford

Add/Change #6852 (DeprecationWarning in admin, caused by recent changes to pagination)




Change Properties
Action