Django

Code

Ticket #6809 (closed: fixed)

Opened 7 months ago

Last modified 4 months ago

[newforms-admin] non_field_errors are not displayed in change_form.html

Reported by: peschler Assigned to: nobody
Milestone: Component: django.contrib.admin
Version: newforms-admin Keywords: nfa-blocker non_field_errors form admin
Cc: framos@yaco.es Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Error messages that don't belong to a field (=form.non_field_errors) are not displayed at the top of the form in the admin change view of a model.

E.g. error messages issued by a custom Form's clean() method are not displayed to the user.

Attached is a simple patch to the change_form.html which fixes the problem and displays all non-field error messages at the top of the form.

Attachments

change_form-non_field_errors.diff (0.6 kB) - added by peschler on 03/17/08 18:39:33.
Patch for displaying non_field_errors.

Change History

03/17/08 18:39:33 changed by peschler

  • attachment change_form-non_field_errors.diff added.

Patch for displaying non_field_errors.

03/17/08 21:07:27 changed by peschler

  • needs_better_patch changed.
  • summary changed from non_field_errors are not displayed in change_form.html to [newforms-admin] non_field_errors are not displayed in change_form.html.
  • needs_tests changed.
  • needs_docs changed.

03/18/08 12:17:38 changed by brosner

  • keywords changed from non_field_errors form admin to nfa-blocker non_field_errors form admin.
  • stage changed from Unreviewed to Accepted.

05/01/08 10:09:44 changed by framos

  • cc set to framos@yaco.es.

06/09/08 23:45:20 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7607]) newforms-admin: Fixed #6809 -- non_field_errors are now properly displayed. Thanks peschler.

Add/Change #6809 ([newforms-admin] non_field_errors are not displayed in change_form.html)




Change Properties
Action