Django

Code

Ticket #6802 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

NFA: Test for forms changes MEDIA_URL, but it doesn't change it back (may cause test fail)

Reported by: ales_zoulek Assigned to: nobody
Milestone: Component: django.newforms
Version: newforms-admin Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

/tests/regressiontests/forms/media.py changes MEDIA_URL to 'http://media.example.com/media/', but test for admin_widgets is constructed using the old MEDIA_URL.

That may cause error in

 >>> w = AdminFileWidget()
 >>> print conditional_escape(w.render('test', 'test'))
======================================================================
FAIL: Doctest: regressiontests.admin_widgets.models.__test__.WIDGETS_TESTS
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/al3x/programy/pythonpath/django/test/_doctest.py", line 2180, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for regressiontests.admin_widgets.models.__test__.WIDGETS_TESTS
  File "/home/al3x/programy/django_git/tests/regressiontests/admin_widgets/models.py", line unknown line number, in WIDGETS_TESTS

----------------------------------------------------------------------
File "/home/al3x/programy/django_git/tests/regressiontests/admin_widgets/models.py", line ?, in regressiontests.admin_widgets.models.__test__.WIDGETS_TESTS
Failed example:
    print conditional_escape(w.render('test', 'test'))
Expected:
    Currently: <a target="_blank" href="test">test</a> <br />Change: <input type="file" name="test" />
Got:
    Currently: <a target="_blank" href="http://media.example.com/media/test">test</a> <br />Change: <input type="file" name="test" />


----------------------------------------------------------------------

Attachments

forms_media_test.patch (0.7 kB) - added by ales_zoulek on 03/17/08 12:40:51.

Change History

03/17/08 12:38:19 changed by brosner

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

03/17/08 12:40:51 changed by ales_zoulek

  • attachment forms_media_test.patch added.

03/17/08 12:42:25 changed by ales_zoulek

  • has_patch set to 1.

03/17/08 14:21:13 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7273]) newforms-admin: Fixed #6802 -- regressiontests/forms/media.py perserves the MEDIA_URL once finished. Thanks, ales_zoulek.


Add/Change #6802 (NFA: Test for forms changes MEDIA_URL, but it doesn't change it back (may cause test fail))




Change Properties
Action