Django

Code

Ticket #6610 (assigned)

Opened 3 years ago

Last modified 2 years ago

don't hardcode flup fastcgi traceback off

Reported by: jedie Assigned to: michel (accepted)
Milestone: Component: Core framework
Version: SVN Keywords: fastCGI, flup
Cc: django@jensdiemer.de Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

In [4170] the flup traceback are hardcoded turn off. I think this is not the best way. The Traceback should be per default disable. But it should be possible to turn the traceback on via runfastcgi() options.

Attachments

patch.txt (0.7 kB) - added by jedie on 02/15/08 10:14:40.
trac-6610.diff (2.1 kB) - added by michel on 09/12/08 07:21:10.
Allow to specify a debug parameter to runfcgi that is passed to flup and allows for traceback pages. Default is False.

Change History

02/15/08 10:14:40 changed by jedie

  • attachment patch.txt added.

03/06/08 08:46:57 changed by jedie

  • cc set to django@jensdiemer.de.
  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

03/19/08 14:24:55 changed by PhiR

  • needs_better_patch set to 1.
  • needs_docs set to 1.

It seems your patch doesn't allow setting the option. The value gets lost because it sits in fcgi_options and is never copied to wsgi_options. Plus you didn't document the extra command-line argument.

06/14/08 10:44:51 changed by programmerq

  • stage changed from Unreviewed to Accepted.

09/12/08 07:21:10 changed by michel

  • attachment trac-6610.diff added.

Allow to specify a debug parameter to runfcgi that is passed to flup and allows for traceback pages. Default is False.

09/12/08 07:22:49 changed by michel

  • needs_better_patch deleted.
  • needs_docs deleted.

I updated my patch to include documentation.

09/12/08 07:40:45 changed by michel

  • owner changed from nobody to michel.
  • status changed from new to assigned.

Add/Change #6610 (don't hardcode flup fastcgi traceback off)




Change Properties
Action