remove django.templates __path__ hacking

new template library loader

better error messages, no conflicting library names, better naming of variables

Do not walk subdirs in os.walk

get_library no longer uses django.templatetags.module

all tests in runtests.py templates now pass

A good start. Needs a little more tweaking, though.

Line 19 in the new version of templatetags/__init__.py can't be right. It looks like you're trying to replicate Python's import behaviour, but that's not the way to do it. I would be cautious of anything trying to do with this work without using at least some functions from Python's imp module. See below (the "Finally,..." paragraph) for more here: I feel a bit suspicious about the whole approach in this part of the code.

Lines 8 and 9 in the same file cry out for a better solution. One possible, probably for another ticket, is to add a "tags to load always" list in settings. This would help people who are poking into the builtin tags as well. We could add django.templatetags.* to that list.

Even simpler, and probably sufficient for the purposes of this ticket is to iterate over ['django'] + list(settings.INSTALLED_APPS). That avoids having some special list we have to remember to update if we add more tags in there.

Finally, the approach in get_library_names() looks complex. You're doing a lot of computation there in the hope of getting one hit on the returned dictionary when you try to load a tag. Is it possible to let Python do more of the work here. Loop over the list of directories (<app_name>+'.templatetags') and try appending what is being loaded to the end of that and importing. As soon as you don't get an import error, stop with success. That will also mean if you try to load the same template tags in multiple templates in the the same process, Python will just reuse the one already in memory, instead of walking all those directories again. Push less of the work down into get_library_names() and try to use Python's builtin import facilities (esp. __import__() a bit more.

More use of import, tests pass

populate app_label in templatetags/init..py, import_library is own function

better naming of variables, some code fixes, added some docstrings

All tests pass

#3349 talks about ImportError? in template loading.

This patch shows the tried modules, should the message be less specific, and ask about apps in INSTALLED_APPS as in #3349?

removed os import

I prefer to know the tried modules, just pointed out #3349 in case it gets invalidated whe this one gets in. But I doubt it now as I changed #3349 summary (as the patch fixed other places with obscure errors).

See also #6579 regarding the use of [''] as the 4th. parameter to ___init__() (with some notes from the Python developers advising against its use.)

fixed import to get the correct module, moved defaulttags and defaultfilters to avoid circular imports, fixes #6579

forgot to remove some files in the commit, again

new loader using imp, may need some cleaup, and decide if add_to_builtins should change, and if a import should use a list instead of the getattr solution

removed import using getattr

Final patch, i hope :)

1.0 beta has shipped and this was not fixed, will be handled post-1.0.

I realise people are only trying to help, but can we have a little restraint with triaging tickets off the feature list? Particularly when a maintainer is currently the assigned person. This is still on the 1.0 track. I can do it in a more-or-less backwards-compatible way, with luck.