Django

Code

Ticket #6508 (closed: fixed)

Opened 10 months ago

Last modified 10 months ago

contrib.syndication feed links break with https-urls

Reported by: Uninen Assigned to: nobody
Milestone: Component: RSS framework
Version: SVN Keywords: url, feeds, https, syndication, contrib.syndication
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The current add_domain-method checks if the link URL starts with 'http://' so it breaks with URLs that start with 'https://'.

I searched for previous mentions about this bug but didn't find any tickets. Attached one-line patch changes the method so that it checks both http and https.

Attachments

add_domain.diff (0.6 kB) - added by Uninen on 01/29/08 14:52:22.
Fixed diff root

Change History

01/29/08 14:52:22 changed by Uninen

  • attachment add_domain.diff added.

Fixed diff root

01/29/08 19:50:52 changed by Simon Greenhill <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

01/31/08 16:31:39 changed by gwilson

  • status changed from new to closed.
  • resolution set to fixed.

(In [7050]) Fixed #6508 -- Fixed add_domain function to also work with https feed URLs, thanks Uninen.

Add/Change #6508 (contrib.syndication feed links break with https-urls)




Change Properties
Action