Django

Code

Ticket #6492 (closed: fixed)

Opened 5 months ago

Last modified 4 months ago

isValidFloat() should handle Unicode data

Reported by: Bastian Kleineidam <calvin@debian.org> Assigned to: nobody
Milestone: Component: Template system
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The isValidFloat() can receive Unicode data in which case str() fails. The patch uses smart_str() to cope with this.

Attachments

0023-isValidFloat-should-handle-Unicode-data.patch (1.3 kB) - added by Bastian Kleineidam <calvin@debian.org> on 01/28/08 10:24:07.
django-isvalidfloat-test.diff (0.7 kB) - added by Bastian Kleineidam <calvin@debian.org> on 02/08/08 02:49:01.
unittest for isValidFloat() unicode fix

Change History

01/28/08 10:24:07 changed by Bastian Kleineidam <calvin@debian.org>

  • attachment 0023-isValidFloat-should-handle-Unicode-data.patch added.

01/31/08 22:41:04 changed by anonymous

  • needs_better_patch changed.
  • component changed from Uncategorized to Template system.
  • needs_tests changed.
  • needs_docs changed.

02/01/08 01:22:22 changed by SmileyChris

  • needs_tests set to 1.
  • stage changed from Unreviewed to Accepted.

Straight-forwards patch, but may as well have a regression test...

02/08/08 02:49:01 changed by Bastian Kleineidam <calvin@debian.org>

  • attachment django-isvalidfloat-test.diff added.

unittest for isValidFloat() unicode fix

02/08/08 02:49:17 changed by Bastian Kleineidam <calvin@debian.org>

  • needs_tests deleted.

02/08/08 03:10:17 changed by SmileyChris

  • stage changed from Accepted to Ready for checkin.

Good good (next time, just combine the tests with the actual fix into one patch)

03/17/08 09:05:44 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7258]) Fixed #6492 -- Added bullet-proofing to isValidFloat validator. Thanks, Bastian Kleineidam.

Add/Change #6492 (isValidFloat() should handle Unicode data)




Change Properties
Action