Django

Code

Ticket #6465 (closed: fixed)

Opened 5 months ago

Last modified 5 months ago

MergeDict only calls getlist on its first merged dict

Reported by: mattmcc Assigned to: nobody
Milestone: Component: Core framework
Version: SVN Keywords: multivaluedict mergedict
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Since MultiValueDict.getlist doesn't raise a KeyError, MergeDict.getlist will only call getlist() on its first dict. This results in request.REQUEST being unable to retrieve a list of values from request.GET.

Attachments

6465-1.diff (1.3 kB) - added by mattmcc on 01/26/08 01:43:20.

Change History

01/26/08 01:43:20 changed by mattmcc

  • attachment 6465-1.diff added.

01/26/08 01:44:19 changed by mattmcc

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

01/30/08 20:07:22 changed by SmileyChris

  • stage changed from Unreviewed to Ready for checkin.

02/02/08 20:02:42 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7062]) Fixed #6465 -- Tweaked MergeDict?.getlist() to work with Django's MultiValueDict? class. Thanks, Matt McClanahan?.

Add/Change #6465 (MergeDict only calls getlist on its first merged dict)




Change Properties
Action