Django

Code

Ticket #6394 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

custom_sql_for_model(): Small patch to remove comments better

Reported by: Thomas Güttler <hv@tbz-pariv.de> Assigned to: nobody
Milestone: Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Hi,

this is a small patch to remove comments from custom sql files better.

My custom sql file started like this: 

-- CREATE LANGUAGE "plpythonu";

-- Comment

Before my patch the first sql command was '-- CREATE LANGUAGE "plpythonu";' this caused an empty ProgrammingError with psycopg2.

Attachments

sql_comments.diff (0.6 kB) - added by Thomas Güttler <hv@tbz-pariv.de> on 01/16/08 08:16:35.

Change History

01/16/08 08:16:35 changed by Thomas Güttler <hv@tbz-pariv.de>

  • attachment sql_comments.diff added.

03/11/08 15:34:41 changed by jacob

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

06/08/08 00:38:14 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [7591]) Fixed #6394: improved comment stripping in initial SQL files. Thanks, Thomas Guttler.

09/04/08 10:01:55 changed by guettli

  • cc deleted.

Add/Change #6394 (custom_sql_for_model(): Small patch to remove comments better)




Change Properties
Action