make-messages.py don't follow symlinks

[Adrian <aribao@…>]

I have created a repository with my apps, and when I need one for one of my projects, I link the code from the repository to the project path. This give me a problem.
When I want to use make-messages to extract all the translation strings, it doesn't follow this symbolic links.
I have patched make-messages.py to be able to extract the strings from the applications linked to the project.
I hope it helps.

[Adrian <aribao@…>]

Patch to allow make-messages.py follow symbolic links

[aribao@…]

I'd like to make some improvements in this patch, what should I do? Something missing?
Thank you.

[Malcolm Tredinnick]

If you want to upload a new patch, just do so. We'll only ever worry about the last patch.

There are a few improvements needed here, though:

1. It doesn't need a nested function like this. Just declare a top-level function. It's much easier to read because there's no confusion about which code belongs to which function.
2. Needs to be formatted as per PEP 8. In particular, no spaces after parentheses and spaces after commas.
3. You seem to be going to a lot of effort to reinvent the behaviour of os.walk here. Why not just continue to use os.walk() to descend the directories and use the tip in the Python docs for os.walk for handling symlinks? That would require less extra code, I suspect, plus will use the already debugged os.walk() function instead of having to reinvent our own version.

[Ramiro Morales]

The followlinks parameter of os.walk() was added in Python 2.6.

[Jannis Leidel]

(In [12443]) Fixed #6380 - Follow symlinks when examining source code and templates for translation strings.