Opened 17 years ago

Closed 14 years ago

#6372 closed (fixed)

archive_week generic views should default allow_empty to False

Reported by: David Paccoud Owned by: nobody
Component: Generic views Version: dev
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In ticket #685, it has been decided that allow_empty parameter should default to True for index generic views. archive_week in not considered an index view here (as archive_year, archive_month or archive_day) but it is the only generic view where allow_empty default to True from the beginning.

I think it would make sens, for better consistency, that the allow_empty parameter default to False in archive_week. This would break backwards compatibility.

Attachments (1)

fix_allow_empty.diff​ (1.3 KB ) - added by David Paccoud 17 years ago.
Fix allow_empty in archive_week generic view

Download all attachments as: .zip

Change History (3)

by David Paccoud, 17 years ago

Attachment: fix_allow_empty.diff​ added

Fix allow_empty in archive_week generic view

comment:1 by Simon Greenhill <dev@…>, 17 years ago

Triage Stage: Unreviewed → Design decision needed

comment:2 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

This has been addressed as part of the introduction of class-based views in [14254].

Note: See TracTickets for help on using tickets.
Back to Top