Django

Code

Ticket #6356 (closed: fixed)

Opened 1 year ago

Last modified 10 months ago

EasyInstance url() not marked safe

Reported by: tangerine Assigned to: nobody
Milestone: Component: django.contrib.databrowse
Version: SVN Keywords: databrowse
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

While using the databrowse app I noticed that the url method of EasyInstance? is not marking the returned string as safe. I've attached a patch which marks this safe as well as a change to the __repr__ method of EasyModel? to match the use of smart_str() as on other other classes.

Attachments

datastructures.diff (1.0 kB) - added by tangerine on 01/10/08 05:56:11.
Patch

Change History

01/10/08 05:56:11 changed by tangerine

  • attachment datastructures.diff added.

Patch

01/13/08 06:06:59 changed by Simon Greenhill <dev@simon.net.nz>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

02/02/08 19:52:50 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7061]) Fixed #6356 -- Added a mark_safe() call that was missed in a url() method. Thanks, tangerine.

Add/Change #6356 (EasyInstance url() not marked safe)




Change Properties
Action