Opened 18 years ago

Closed 18 years ago

#6356 closed (fixed)

EasyInstance url() not marked safe

Reported by: tangerine Owned by: nobody
Component: contrib.databrowse Version: dev
Severity: Keywords: databrowse
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

While using the databrowse app I noticed that the url method of EasyInstance is not marking the returned string as safe. I've attached a patch which marks this safe as well as a change to the __repr__ method of EasyModel to match the use of smart_str() as on other other classes.

Attachments (1)

datastructures.diff​ (993 bytes ) - added by tangerine 18 years ago.
Patch

Download all attachments as: .zip

Change History (3)

by tangerine, 18 years ago

Attachment: datastructures.diff​ added

Patch

comment:1 by Simon Greenhill <dev@…>, 18 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin

comment:2 by Malcolm Tredinnick, 18 years ago

Resolution: → fixed
Status: new → closed

(In [7061]) Fixed #6356 -- Added a mark_safe() call that was missed in a url() method. Thanks, tangerine.

Note: See TracTickets for help on using tickets.
Back to Top