Django

Code

Ticket #6320 (closed: fixed)

Opened 8 months ago

Last modified 3 months ago

contributing.txt is not specific enought about Triaging

Reported by: telenieko Assigned to: telenieko
Milestone: Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

There are some points missed in the triaging section of contributing.txt, those points can lead to things like:

  • #2415, when a ticket was closed as wontfix.
  • #689, comment 22
  • #399, which even added a discusion.

We have threads asking for clarification also like this one.

So I'm trying to take some bits out of this thread and clarify contributing.txt a bit.

I just opened this ticket so anybody knows I'm working on it! ;)

Attachments

6320.diff (2.9 kB) - added by telenieko on 01/05/08 10:02:10.
The third role
djangotickets.png (57.3 kB) - added by telenieko on 01/05/08 10:26:10.
not perfect but should give a visual idea of the patch.
6320_remix.diff (2.8 kB) - added by telenieko on 01/24/08 06:01:50.
New patch

Change History

01/05/08 10:02:10 changed by telenieko

  • attachment 6320.diff added.

The third role

01/05/08 10:05:32 changed by telenieko

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

Done it, I took most of the things from django-developers group.

mostly I've created a "third role" making a clear distinction between a Trusted Triager (one officially recognised) and a Community Triager (one that helps out triaging sometimes to keep the tracker clean).

On this new role I added the points in which those should be careful, stating the differences between being a triager with a "proven criteria" and one "still proving criteria".

Hope this helps out volunteers who want to triage bugs.

01/05/08 10:26:10 changed by telenieko

  • attachment djangotickets.png added.

not perfect but should give a visual idea of the patch.

01/20/08 19:24:02 changed by SmileyChris

  • stage changed from Unreviewed to Design decision needed.

Thanks for the work telenieko - this is a necessary clarification. Perhaps just "community members" rather than "community triagers"

I'd like to get some opinions on this from the core crew, so could you bring this up in django-dev please?

(for example, I'm not sure community members should ever be pushing the triage stage past a design decision)

01/24/08 06:01:50 changed by telenieko

  • attachment 6320_remix.diff added.

New patch

01/24/08 06:03:24 changed by telenieko

  • owner changed from nobody to telenieko.
  • status changed from new to assigned.

Brought in some changes recommended by SmileyChris? and Russell Keith-Magee, that makes unnecessary the change of djangotickets.png.

Also, discussion has been brought to django-developers in this thread

(follow-up: ↓ 5 ) 06/13/08 12:11:37 changed by edgarsj

  • stage changed from Design decision needed to Ready for checkin.

Marking ready for checkin as discussed at the end of this django-developers thread.

(in reply to: ↑ 4 ) 06/14/08 05:29:51 changed by telenieko

Replying to edgarsj:

Marking ready for checkin as discussed at the end of this django-developers thread.

Nice!!!!!!! Commiter: NOTE that the attached .png image does not need to be commited, the latest patch made it unnecesary.

06/14/08 08:44:50 changed by russellm

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [7632]) Fixed #6320 -- Clarified a few issues in the contribution docs surrounding the triage process. Thanks to telenieko, Edgars Jekabsons and Marc Fargas for their input.

Add/Change #6320 (contributing.txt is not specific enought about Triaging)




Change Properties
Action