Django

Code

Ticket #6303 (closed: fixed)

Opened 8 months ago

Last modified 7 months ago

Language parameter is not handled the right way in SyndicationFeed, force_unicode should be replaced by to_unicode

Reported by: david Assigned to: nobody
Milestone: Component: RSS framework
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

This way, "if self.feed['language'\] is not None:" test succeed, otherwise self.feed['language'] == u'None' and this test always returns False which results in xml:lang="None" attribute in the feed header.

Attachments

patch_django_6303.diff (0.6 kB) - added by david on 01/02/08 12:21:10.
One-line patch

Change History

01/02/08 12:21:10 changed by david

  • attachment patch_django_6303.diff added.

One-line patch

01/06/08 21:59:47 changed by Simon Greenhill <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

02/02/08 21:23:11 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7066]) Fixed #6303 -- Handle missing language specification in feed generation. Thanks, david.

Add/Change #6303 (Language parameter is not handled the right way in SyndicationFeed, force_unicode should be replaced by to_unicode)




Change Properties
Action