[patch] (reopened) Support for non-standard database port

[Esaj]

This patch adds support for non-standard database ports, by specifying DATABASE_PORT. Tested with PostgreSQL, but not with MySQL.

[ian@…]

Hi.
I tried your patch on mysql, and it was complaining about wanting an integer and not a string for a port.
by placing DATABASE_PORT=3306 (which is the default) in global_settings.py it stopped complaining.

[Adrian Holovaty]

(In [858]) Fixed #618 -- Added DATABASE_PORT setting. Thanks, Esaj

[wmealing@…]

For others who might be seeing this problem.

python manage.py init
Error: The database couldn't be initialized.
an integer is required

settings.py should have

DATABASE_PORT = 3306 <-- note the integer

not

DATABASE_PORT = '3306' <-- note the quotes.

[matt]

I think that we should be setting this as a string in the settings file and converting it to an int for MySQL (this doesn't look like an issue for Postgres and it has not been implemented in MSSQL). All of the other database settings are strings and we ship the settings file with DATABASE_PORT = '' # Set to empty string for default. Not used with sqlite3.

Here are two quick patches to take care of this:

magic-removal:

Index: django/core/db/backends/mysql.py
===================================================================
--- django/core/db/backends/mysql.py	(revision 2475)
+++ django/core/db/backends/mysql.py	(working copy)
@@ -63,7 +63,7 @@
                 'conv': django_conversions,
             }
             if DATABASE_PORT:
-                kwargs['port'] = DATABASE_PORT
+                kwargs['port'] = int(DATABASE_PORT)
             self.connection = Database.connect(**kwargs)
         cursor = self.connection.cursor()
         if self.connection.get_server_info() >= '4.1':

Trunk:

Index: django/db/backends/mysql/base.py
===================================================================
--- django/db/backends/mysql/base.py	(revision 2475)
+++ django/db/backends/mysql/base.py	(working copy)
@@ -62,7 +62,7 @@
                 'conv': django_conversions,
             }
             if settings.DATABASE_PORT:
-                kwargs['port'] = settings.DATABASE_PORT
+                kwargs['port'] = int(settings.DATABASE_PORT)
             self.connection = Database.connect(**kwargs)
         cursor = self.connection.cursor()
         if self.connection.get_server_info() >= '4.1':

[matt]

changed summary.

[eugene@…]

I think Matt mistyped his patches: 1st patch should be applied to the trunk, and 2nd patch is for magic-removal.

[matt]

Eugene is correct, sorry about that.

[Jacob]

(In [2614]) magic-removal: fixed #618 -- the mysql backend now tolerates strings in DATABASE_PORT