Django

Code

Ticket #6109 (closed: fixed)

Opened 1 year ago

Last modified 4 months ago

Fieldset description is autoescaped in admin

Reported by: Øyvind Saltvik <oyvind@saltvik.no> Assigned to: nobody
Milestone: Component: django.contrib.admin
Version: SVN Keywords: autoescaped fieldset
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templates/admin/change_form.html#L37

Should add a |safe for the description since the docs says it should not be escaped

Attachments

description_autoescape.diff (0.9 kB) - added by SomeGuy <SomeGuy@example.net> on 12/11/07 01:16:02.

Change History

12/11/07 01:16:02 changed by SomeGuy <SomeGuy@example.net>

  • attachment description_autoescape.diff added.

12/11/07 01:17:01 changed by SomeGuy <SomeGuy@example.net>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

01/24/08 16:32:37 changed by SmileyChris

  • stage changed from Accepted to Ready for checkin.

Yep, the docs clearly state that it shouldn't be escaped: http://www.djangoproject.com/documentation/model-api/#description

02/03/08 01:39:10 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [7078]) Fixed #6109 -- Marked fieldset descriptions as safe from auto-escaping. Good catch, SomeGuy?.

07/25/08 08:45:56 changed by lukeplant

  • status changed from closed to reopened.
  • resolution deleted.

07/25/08 08:46:25 changed by lukeplant

This is broken again, since newforms-admin was merged I think.

07/25/08 09:44:57 changed by lukeplant

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8073]) Fixed #6109 again.

Add/Change #6109 (Fieldset description is autoescaped in admin)




Change Properties
Action