Django

Code

Ticket #6100 (closed: fixed)

Opened 9 months ago

Last modified 6 months ago

newforms-admin: popup won't be dismissed when adding

Reported by: oggie_rob Assigned to: nobody
Milestone: Component: Admin interface
Version: newforms-admin Keywords: nfa-blocker
Cc: davidgrant@gmail.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When you add a related field via newforms-admin, the popped up window isn't dismissed properly because of a javascript error. This is due to the value being passed into the html_unescape() function - it is an integer but the function is expecting a string.

Attachments

6100.diff (0.6 kB) - added by oggie_rob on 12/02/07 04:06:29.
one-liner fix
6100.2.diff (1.0 kB) - added by gwilson on 12/03/07 21:04:12.

Change History

12/02/07 04:06:29 changed by oggie_rob

  • attachment 6100.diff added.

one-liner fix

12/02/07 13:55:05 changed by Simon G <dev@simon.net.nz>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

12/03/07 14:42:36 changed by anonymous

  • version changed from SVN to newforms-admin.

12/03/07 16:21:15 changed by brosner

Marked #6104 as a duplicate.

12/03/07 21:03:51 changed by gwilson

[6691] did not get merged correctly to newforms-admin.

12/03/07 21:04:12 changed by gwilson

  • attachment 6100.2.diff added.

12/03/07 22:53:43 changed by jkocherhans

Any reason you haven't committed/closed this Gary?

12/03/07 23:46:12 changed by gwilson

I don't have the permissions to commit to newforms-admin.

12/07/07 18:07:00 changed by brosner

  • keywords set to nfa-blocker.

I have also come across this problem. This needs to be included before the merge of newforms-admin.

01/19/08 03:15:32 changed by dgrant

  • cc set to davidgrant@gmail.com.

When I was using newforms-admin at the beginning of January I didn't see this bug but now I do for some reason.

02/15/08 13:30:33 changed by Alex

  • component changed from Uncategorized to Admin interface.

03/04/08 21:56:21 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7194]) newforms-admin: Fixed #6100 -- Related field popup window now closes properly after saving. Thanks oggie_rob and Gary Wilson.

Add/Change #6100 (newforms-admin: popup won't be dismissed when adding)




Change Properties
Action