contrib.auth still uses oldforms

I've made the changes to contrib.auth (my first Django patch!). The oldforms are used in contrib.admin and contrib.comments, and I have patched these too. Contrib.admin now uses the newforms in authentication forms. contrib.comments subclasses the oldform AuthenticationForm?, and has heavy reliance on validators so I made a copy of AuthenticationForm? and put it in comments.py.

I'll update the documentation if the approach seems sound. Shall I also update the newforms branch?

Marked #6318 as duplicate. It has a patch as well so perhaps they needed to be merged unless they really accomplished the same exact thing with little differences.

I encountered the following error when using Django's test framework fake web client (django.test.client.Client):

----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gmaps/test/tilecache/an/portal/test_login.py", line 72, in testLoginWorks
    resp = self.client.post(self.loginurl, { 'username': self.u1, 'password': self.p1 })
  File "/home/gmaps/django-test//lib/python2.4/site-packages/django/test/client.py", line 238, in post
    return self.request(**r)
  File "/home/gmaps/django-test//lib/python2.4/site-packages/django/core/handlers/base.py", line 82, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/home/gmaps/django-test//lib/python2.4/site-packages/django/contrib/auth/views.py", line 23, in login
    request.session.delete_test_cookie()
  File "/home/gmaps/django-test//lib/python2.4/site-packages/django/contrib/sessions/backends/base.py", line 69, in delete_test_cookie
    del self[self.TEST_COOKIE_NAME]
  File "/home/gmaps/django-test//lib/python2.4/site-packages/django/contrib/sessions/backends/base.py", line 38, in __delitem__
    del self._session[key]
KeyError: 'testcookie'

----------------------------------------------------------------------

And this was happening because I was just POSTing to the login form with the "username" and "password" values without setting the test cookie. Then sessions.delete_test_cookie() tries to delete the cookie regardless of whether it exists or not (this seems like a bug to me...), and instead of getting an error message or anything, it just crashes. I added a one-liner fix:

--- views.py-old        2008-01-18 00:08:10.000000000 +0000
+++ views.py    2008-01-18 00:08:19.000000000 +0000
@@ -20,7 +20,8 @@
                 redirect_to = settings.LOGIN_REDIRECT_URL
             from django.contrib.auth import login
             login(request, form.get_user())
-            request.session.delete_test_cookie()
+            if request.session.test_cookie_worked():
+                request.session.delete_test_cookie()
             return HttpResponseRedirect(redirect_to)
     else:
         form = AuthenticationForm(request=request)

The updated patch I will attach contains this tweak and is against a more recent SVN rev so the patch applies cleanly.

includes a one-liner update for delete_test_cookie() problem

Fixed reference to comments.auth.py and added fix to admin.templates.admin.auth.user.change_password.html for new forms and slight change to the way contrib.auth.forms.AdminPasswordChangeForm? cleans the form, and changed auth.views.py to use AdminPasswordChangeForm? instead of the now nonexistent old form way

I tried another approach for this problem - not to remove oldforms versions, but to add newforms version only. I think it is not necessary to force everybody to port authorization code at once.

Another idea is to port "post data" logins (without redirections, with saving of post data) from oldforms-admin and newforms-admin to auth - so newforms-admin wouldn't need any authorization code. New parameter extra_context (#5298) is necessary for it - newforms-admin needs more context variables.

I am not sure that this patch works fully - I have checked only some forms. (It should be part of bigger series of tickets which is not ready.) I mean my patch mainly as a comment now. (I read about this ticket today on django-developers.)

fixes a few issues and changes the user add view into newforms

This new patch does not have an import of django.contrib.auth.admin in it, because while using auth multiple calls need to be made to models, auth (init), forms, etc. I never received a design decision from https://groups.google.com/group/django-developers/browse_thread/thread/ba8b115b74d6e502 . I would like to take Petr's patch to Django Devs as well, it is my opinion that as new forms merges into the trunk switches need to be made to all of admin and, in all reality, the switch of Auth would be relatively automatic.

patch against newforms-admin.

I have added a patch against newforms-admin. I will eventually be committing the final patch there. My patch current breaks comments since it had dependancy on the oldforms AuthenticationForm?. I will be looking more into whether just moving the oldforms version over will be correct way.

Development of this patch can be found at http://github.com/brosner/django/tree/newforms_auth

more complete with tests and docs. looking for feedback.

I have attached a more complete version of the patch. I have moved some files in django.contrib.auth.tests to make it easier for other parts of the app.

(In [7191]) newforms-admin: Fixed #6083 -- Updated django.contrib.auth to use newforms. A big thanks to Greg Turner, Michael Newman and Petr Marhoun.

(In [7525]) newforms-admin: Cleaned up imports, refs #6083.