Django

Code

Ticket #6004 (closed: fixed)

Opened 1 year ago

Last modified 5 months ago

Useless code in newforms admin

Reported by: Petr Marhoun <petr.marhoun@gmail.com> Assigned to: nobody
Milestone: 1.0 alpha Component: django.contrib.admin
Version: newforms-admin Keywords: nfa-blocker
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

There is too much not used code in newforms admin. It is quite difficult to understand django.contrib.admin if there are many obsolete things. I don't feel it is useful as documentation - there are too many changes and almost everything is ported now.

For example:

  • urls.py - replaced by sites.ModelAdmin.root and options.ModelAdmin.call
  • templates.widget - replaced by widgets.py
  • almost everything in templatetags.admin_modify and views.main.AdminBoundField - replaced by widgets.py and wrappers from options
  • views.main.model_admin_view and views.main.index - moved to sites.ModelAdmin

Attachments

00-admin-useless-code.diff (10.5 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/20/07 23:41:18.
00-admin-useless-code.2.diff (10.5 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/20/07 23:42:08.
00-admin-useless-code.3.diff (10.5 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/30/07 09:32:38.
new version - after autoescape merge
00-admin-useless-code.4.diff (10.6 kB) - added by programmerq on 06/21/08 14:11:54.

Change History

11/20/07 23:41:18 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-useless-code.diff added.

11/20/07 23:42:08 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-useless-code.2.diff added.

11/20/07 23:43:12 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

I don't know why but my patch is not showed by trac. It can be download as original format.

11/30/07 09:32:38 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-useless-code.3.diff added.

new version - after autoescape merge

12/08/07 06:53:56 changed by Karen Tracey <kmtracey@gmail.com>

  • keywords set to nfa-blocker.

I think it would make sense to clean things up before merge, so I'm marking this blocking. TPTB can of course feel free to disagree & override.

03/17/08 12:59:51 changed by MichaelBishop

  • stage changed from Unreviewed to Design decision needed.

Decision needed - it's been 4 months since these diff's were submitted, perhaps they are no longer relevant to the currnt SVN branch of NFA?

06/16/08 10:48:06 changed by garcia_marc

  • milestone set to 1.0 alpha.

06/21/08 14:11:54 changed by programmerq

  • attachment 00-admin-useless-code.4.diff added.

06/21/08 14:12:35 changed by programmerq

Updated patch to apply cleanly.

06/21/08 14:13:30 changed by programmerq

  • stage changed from Design decision needed to Ready for checkin.

06/24/08 15:06:15 changed by lukeplant

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r7736

Add/Change #6004 (Useless code in newforms admin)




Change Properties
Action