Django

Code

Ticket #5999 (closed: fixed)

Opened 1 year ago

Last modified 6 months ago

Broken expired session in newforms-admin

Reported by: Petr Marhoun <petr.marhoun@gmail.com> Assigned to: Mnewman
Milestone: Component: django.contrib.admin
Version: newforms-admin Keywords: nfa-blocker
Cc: purdeaandrei@yahoo.com, favo@exoweb.net Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

If session expires in newforms-admin (try to remove everything from django_session table), non-existing method view_func is called.

Attachments

00-admin-expired-session.diff (1.1 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 11/20/07 21:55:57.
alternative.diff (0.7 kB) - added by purdeaandrei on 02/24/08 18:59:16.
alternative2.diff (1.0 kB) - added by favo <favo@exoweb.net> on 03/18/08 19:58:52.
nfa-expired-session-5999.patch (2.4 kB) - added by Mnewman on 06/10/08 09:29:54.
New patch with tests, applied against r7609

Change History

11/20/07 21:55:57 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment 00-admin-expired-session.diff added.

12/10/07 10:37:18 changed by brosner

  • keywords set to nfa-blocker.
  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

Looks good to me. This is a critical fix that needs to be in newforms-admin before a merge.

02/24/08 18:59:16 changed by purdeaandrei

  • attachment alternative.diff added.

02/24/08 19:04:40 changed by purdeaandrei

  • cc set to purdeaandrei@yahoo.com.

i also added an alternative

(follow-up: ↓ 5 ) 03/18/08 11:57:41 changed by brosner

  • stage changed from Ready for checkin to Accepted.

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

03/18/08 19:58:09 changed by favo <favo@exoweb.net>

  • cc changed from purdeaandrei@yahoo.com to purdeaandrei@yahoo.com, favo@exoweb.net.

03/18/08 19:58:52 changed by favo <favo@exoweb.net>

  • attachment alternative2.diff added.

(in reply to: ↑ 3 ) 03/18/08 20:02:35 changed by favo <favo@exoweb.net>

Replying to brosner:

We will be rewriting the URL handling in newforms-admin making this patch obsolete. Bumping down to Accepted so we don't forget about this edge case.

Hope we can still got benefit from django naming URL.

06/10/08 08:48:00 changed by Mnewman

  • owner changed from nobody to Mnewman.
  • needs_tests set to 1.

06/10/08 09:29:54 changed by Mnewman

  • attachment nfa-expired-session-5999.patch added.

New patch with tests, applied against r7609

06/10/08 09:32:12 changed by Mnewman

  • needs_tests deleted.

Tests are added. I liked the way favo changed the login method to expect persistent data.

06/10/08 11:08:00 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7611]) newforms-admin: Fixed #5999 -- When a session expires properly route the flow to call the correct view. Thanks favo and Michael Newman.

06/10/08 11:45:07 changed by bocman1 <Bocman1@i.ua>

http://www.dizmex.com

Add/Change #5999 (Broken expired session in newforms-admin)




Change Properties
Action