Django

Code

Ticket #5939 (closed: fixed)

Opened 10 months ago

Last modified 9 months ago

Localflavor: Canadian province normalization omits New Brunswick

Reported by: rajesh.dhawan@gmail.com Assigned to: rajeshdhawan
Milestone: Component: django.contrib.localflavor
Version: SVN Keywords: canada province new-brunswick
Cc: rajesh.dhawan@gmail.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

A mapping for nb (New Brunswick) is missing in PROVINCES_NORMALIZED in django/contrib/localflavor/ca/ca_provinces.py

This causes django.contrib.localflavor.ca.forms.CAProvinceField to not accept NB as a valid Canadian Province.

Attachments

ca_provinces.diff (447 bytes) - added by rajesh.dhawan@gmail.com on 11/14/07 12:30:40.
Patch to add the missing mapping for "NB"
ca_provinces.2.diff (0.9 kB) - added by rajeshdhawan on 11/14/07 13:13:47.
Better patch to add the missing mapping for "NB" as well as a couple of regression tests

Change History

11/14/07 12:30:40 changed by rajesh.dhawan@gmail.com

  • attachment ca_provinces.diff added.

Patch to add the missing mapping for "NB"

11/14/07 13:12:57 changed by rajeshdhawan

  • owner changed from nobody to rajeshdhawan.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

11/14/07 13:13:47 changed by rajeshdhawan

  • attachment ca_provinces.2.diff added.

Better patch to add the missing mapping for "NB" as well as a couple of regression tests

11/14/07 13:26:21 changed by rajeshdhawan

  • stage changed from Unreviewed to Ready for checkin.

11/29/07 12:16:28 changed by mtredinnick

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in [6744].

Add/Change #5939 (Localflavor: Canadian province normalization omits New Brunswick)




Change Properties
Action