Django

Code

Ticket #5894 (closed: fixed)

Opened 6 months ago

Last modified 2 months ago

FilePathField needs to be updated to newforms

Reported by: Alex Assigned to: jacob
Component: django.newforms Version: SVN
Keywords: FilePathField Cc:
Triage Stage: Ready for checkin Has patch: 1
Needs documentation: 0 Needs tests: 0
Patch needs improvement: 0

Description

FilePathField? still Old Forms in newforms-admin

Attachments

diff.diff (2.2 kB) - added by Alex on 11/08/07 13:00:29.
Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think
diff.2.diff (1.1 kB) - added by Alex on 11/30/07 15:59:58.
Here is the admin field
diff.3.diff (3.2 kB) - added by Alex on 11/30/07 16:05:04.
Both diffs in one!
diff.4.diff (3.1 kB) - added by Alex on 11/30/07 16:16:54.
Putting the max_length back into kwargs
diff.5.diff (3.9 kB) - added by Alex on 12/11/07 10:31:02.
Adds docs, fixes a few small things
diff.6.diff (5.3 kB) - added by Alex on 01/05/08 21:45:08.
diff.7.diff (5.3 kB) - added by Alex on 01/08/08 01:10:44.
Fixes a stupid typo from the previous version
diff.8.diff (5.3 kB) - added by Alex on 01/08/08 02:01:16.
Fixed the tests
diff.9.diff (5.5 kB) - added by Alex on 01/08/08 13:11:37.
Refixed the tests, and made the patch more PEP8(thanks brosner)
diff.10.diff (6.3 kB) - added by Alex on 01/08/08 13:45:24.
Added 2 more test cases
diff.11.diff (6.3 kB) - added by Alex on 01/08/08 13:49:02.
Fixed a bug introduced last patch

Change History

11/08/07 13:00:29 changed by Alex

  • attachment diff.diff added.

Newforms didn't have a filepath field, so I have created one, this should be the first step to fixing the admin, I think

11/11/07 08:52:02 changed by Alex

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests changed.
  • needs_docs changed.

11/30/07 15:59:58 changed by Alex

  • attachment diff.2.diff added.

Here is the admin field

11/30/07 16:00:17 changed by brosner

  • keywords changed from newforms-admin, FilePathField to FilePathField.
  • needs_better_patch set to 1.
  • version changed from newforms-admin to SVN.
  • component changed from Admin interface to django.newforms.
  • summary changed from FilePathField still uses Old Forms in newforms-admin to FilePathField needs to be updated to newforms.

This is actually a bug in newforms and not just newforms-admin. newforms-admin is effected because it uses newforms in the admin.

11/30/07 16:05:04 changed by Alex

  • attachment diff.3.diff added.

Both diffs in one!

11/30/07 16:16:54 changed by Alex

  • attachment diff.4.diff added.

Putting the max_length back into kwargs

11/30/07 16:20:02 changed by SmileyChris

  • needs_better_patch deleted.
  • stage changed from Unreviewed to Accepted.
  • needs_tests set to 1.
  • needs_docs set to 1.

12/11/07 10:31:02 changed by Alex

  • attachment diff.5.diff added.

Adds docs, fixes a few small things

12/11/07 10:31:19 changed by Alex

  • needs_docs deleted.

01/05/08 21:45:08 changed by Alex

  • attachment diff.6.diff added.

01/05/08 21:45:25 changed by Alex

  • needs_tests deleted.

There are now tests.

01/08/08 01:10:44 changed by Alex

  • attachment diff.7.diff added.

Fixes a stupid typo from the previous version

01/08/08 02:01:16 changed by Alex

  • attachment diff.8.diff added.

Fixed the tests

01/08/08 13:11:37 changed by Alex

  • attachment diff.9.diff added.

Refixed the tests, and made the patch more PEP8(thanks brosner)

01/08/08 13:45:24 changed by Alex

  • attachment diff.10.diff added.

Added 2 more test cases

01/08/08 13:49:02 changed by Alex

  • attachment diff.11.diff added.

Fixed a bug introduced last patch

02/20/08 14:10:19 changed by brosner

  • stage changed from Accepted to Ready for checkin.

03/17/08 18:32:05 changed by jacob

  • owner changed from nobody to jacob.

03/19/08 17:29:12 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [7323]) Fixed #5894: added FilePathField? to newforms. Thanks, Alex Gaynor.

Add/Change #5894 (FilePathField needs to be updated to newforms)




Change Properties
Action