Django

Code

Ticket #5890 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Fancy quotes in sitemaps sample code

Reported by: scompt@scompt.com Assigned to: nobody
Milestone: Component: Documentation
Version: SVN Keywords: quotes
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The bit of code on http://www.djangoproject.com/documentation/sitemaps/ under the Initialization header that shows you how to add sitemaps to your urls.py file uses fancy quotes. This means when you copy the line to a text editor, it won't execute properly.

Here's the current line:

(r’^sitemap.xml$’, ‘django.contrib.sitemaps.views.sitemap’, {‘sitemaps’: sitemaps})

And here's the same with non-fancy quotes:

(r'^sitemap.xml$', 'django.contrib.sitemaps.views.sitemap', {'sitemaps': sitemaps})

Attachments

5890.diff (395 bytes) - added by arien <regexbot@gmail.com> on 11/08/07 05:04:14.

Change History

11/08/07 05:04:14 changed by arien <regexbot@gmail.com>

  • attachment 5890.diff added.

11/08/07 05:08:57 changed by arien <regexbot@gmail.com>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

Patch to add the missing colon at the end of the preceding paragraph.

11/10/07 22:44:11 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6667]) Fixed #5890 -- Fixed a ReST markup error. Thanks, arien.

11/28/07 15:04:05 changed by mtredinnick

(In [6724]) Fixed #5890 -- fixed the far edge-case of allowing constant strings inside template template markers: we now treat embedded, escaped double quotes consistently with constant string arguments to filters. Patch from Dmitri Fedortchenko.

11/28/07 15:05:42 changed by mtredinnick

Err.. ignore last commit message. Dyslexia on my part.

Add/Change #5890 (Fancy quotes in sitemaps sample code)




Change Properties
Action