Django

Code

Ticket #5853 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

javascript_catalog i18n view requires english .mo file

Reported by: miracle2k Assigned to: nobody
Milestone: Component: Internationalization
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Django's javascript_catalog view requires a djangojs catalog for the default language "en" for each application installed. This is inconsistent with the requirements for other i18n functionality, and also seems unnecessary, as it basically equates to "don't do any translation".

The attached patch will still attempt to load an english djangojs.mo file, but moves an if that fails.

Attachments

views.i18n_no_en_required.diff (0.8 kB) - added by miracle2k on 11/01/07 03:17:55.

Change History

11/01/07 03:17:55 changed by miracle2k

  • attachment views.i18n_no_en_required.diff added.

11/02/07 23:30:12 changed by Simon G <dev@simon.net.nz>

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

11/29/07 11:16:29 changed by mtredinnick

In future, please create patches from the root of the Django source tree. It makes it much easier to review and apply them (there are three files called i18n.py in the source tree, for example). In this case, I know which file you are patching, so it's okay, so this is just for next time.

11/29/07 11:29:54 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [6739]) Fixed #5853 -- Added handling for a missing 'en' PO file in translation support (this file being missing is essentially harmless). Thanks, miracle2k.

Add/Change #5853 (javascript_catalog i18n view requires english .mo file)




Change Properties
Action